From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 30E7DA0096 for ; Wed, 8 May 2019 18:03:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27F91DE3; Wed, 8 May 2019 18:03:32 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 1CEDB58EC for ; Wed, 8 May 2019 18:03:31 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7098A307E04C; Wed, 8 May 2019 16:03:30 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95B0960C82; Wed, 8 May 2019 16:03:28 +0000 (UTC) From: Kevin Traynor To: Yipeng Wang Cc: Andrey Nikolaev , Pablo de Lara , Dharmik Thakkar , John McNamara , dpdk stable Date: Wed, 8 May 2019 17:02:32 +0100 Message-Id: <20190508160233.2648-35-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 08 May 2019 16:03:30 +0000 (UTC) Subject: [dpdk-stable] patch 'hash: fix doc about thread/process safety' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/f26ab681cf6ab6a83340692018aef0b171df47a2 Thanks. Kevin Traynor --- >From f26ab681cf6ab6a83340692018aef0b171df47a2 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Mon, 29 Apr 2019 02:40:16 -0700 Subject: [PATCH] hash: fix doc about thread/process safety [ upstream commit c96b55df8eea9223ec60f99974a95eb1c305aec5 ] rte_hash_hash is multi-thread safe but not multi-process safe because of the use of function pointers. Previous document and comment says the other way around. This commit fixes the issue. Fixes: fc1f2750a3ec ("doc: programmers guide") Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") Reported-by: Andrey Nikolaev Suggested-by: Pablo de Lara Signed-off-by: Yipeng Wang Acked-by: Dharmik Thakkar Acked-by: John McNamara --- doc/guides/prog_guide/multi_proc_support.rst | 2 +- lib/librte_hash/rte_hash.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst index 6196d3f21..f6f012db1 100644 --- a/doc/guides/prog_guide/multi_proc_support.rst +++ b/doc/guides/prog_guide/multi_proc_support.rst @@ -177,5 +177,5 @@ Some of these are documented below: * The use of function pointers between multiple processes running based of different compiled binaries is not supported, since the location of a given function in one process may be different to its location in a second. - This prevents the librte_hash library from behaving properly as in a multi-threaded instance, + This prevents the librte_hash library from behaving properly as in a multi-process instance, since it uses a pointer to the hash function internally. diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h index e5970b468..4432aef76 100644 --- a/lib/librte_hash/rte_hash.h +++ b/lib/librte_hash/rte_hash.h @@ -464,5 +464,5 @@ rte_hash_lookup_with_hash(const struct rte_hash *h, /** * Calc a hash value by key. - * This operation is not multi-thread safe. + * This operation is not multi-process safe. * * @param h -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:59.219331775 +0100 +++ 0035-hash-fix-doc-about-thread-process-safety.patch 2019-05-08 16:33:57.451576919 +0100 @@ -1 +1 @@ -From c96b55df8eea9223ec60f99974a95eb1c305aec5 Mon Sep 17 00:00:00 2001 +From f26ab681cf6ab6a83340692018aef0b171df47a2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c96b55df8eea9223ec60f99974a95eb1c305aec5 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org