patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'examples/multi_process: fix buffer underrun' has been queued to LTS release 18.11.2
Date: Wed,  8 May 2019 17:02:02 +0100	[thread overview]
Message-ID: <20190508160233.2648-5-ktraynor@redhat.com> (raw)
In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/14/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c35f7d9bc396b94556820bb148c5393d4bfbb8d7

Thanks.

Kevin Traynor

---
From c35f7d9bc396b94556820bb148c5393d4bfbb8d7 Mon Sep 17 00:00:00 2001
From: Yongseok Koh <yskoh@mellanox.com>
Date: Wed, 10 Apr 2019 12:41:54 -0700
Subject: [PATCH] examples/multi_process: fix buffer underrun

[ upstream commit 7c22ccdd91bc91e60f1ee32a3c79192a172dc5ea ]

For client_server_mp, the total number of buffers for the mbuf mempool
should be correctly calculated. Otherwise, having more clients will stop
traffic.

Fixes: af75078fece3 ("first public release")

Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
 .../multi_process/client_server_mp/mp_server/init.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c
index 30c8e44bc..3af5dc699 100644
--- a/examples/multi_process/client_server_mp/mp_server/init.c
+++ b/examples/multi_process/client_server_mp/mp_server/init.c
@@ -38,6 +38,4 @@
 #include "init.h"
 
-#define MBUFS_PER_CLIENT 1536
-#define MBUFS_PER_PORT 1536
 #define MBUF_CACHE_SIZE 512
 
@@ -64,6 +62,13 @@ static int
 init_mbuf_pools(void)
 {
-	const unsigned num_mbufs = (num_clients * MBUFS_PER_CLIENT) \
-			+ (ports->num_ports * MBUFS_PER_PORT);
+	const unsigned int num_mbufs_server =
+		RTE_MP_RX_DESC_DEFAULT * ports->num_ports;
+	const unsigned int num_mbufs_client =
+		num_clients * (CLIENT_QUEUE_RINGSIZE +
+			       RTE_MP_TX_DESC_DEFAULT * ports->num_ports);
+	const unsigned int num_mbufs_mp_cache =
+		(num_clients + 1) * MBUF_CACHE_SIZE;
+	const unsigned int num_mbufs =
+		num_mbufs_server + num_mbufs_client + num_mbufs_mp_cache;
 
 	/* don't pass single-producer/single-consumer flags to mbuf create as it
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-08 16:33:57.759756307 +0100
+++ 0005-examples-multi_process-fix-buffer-underrun.patch	2019-05-08 16:33:57.359579845 +0100
@@ -1 +1 @@
-From 7c22ccdd91bc91e60f1ee32a3c79192a172dc5ea Mon Sep 17 00:00:00 2001
+From c35f7d9bc396b94556820bb148c5393d4bfbb8d7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 7c22ccdd91bc91e60f1ee32a3c79192a172dc5ea ]
+
@@ -11 +12,0 @@
-Cc: stable@dpdk.org

  parent reply	other threads:[~2019-05-08 16:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 16:01 [dpdk-stable] patch 'raw/dpaa2_qdma: fix spin lock release' " Kevin Traynor
2019-05-08 16:01 ` [dpdk-stable] patch 'raw/ifpga: fix file descriptor leak in error path' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'doc: fix spelling reported by aspell in guides' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'doc: fix spelling reported by aspell in comments' " Kevin Traynor
2019-05-08 16:02 ` Kevin Traynor [this message]
2019-05-08 16:02 ` [dpdk-stable] patch 'examples/power: fix buffer overrun' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'examples/power: fix json null termination' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'eal: fix formatting of hotplug error message' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'ipc: fix memory leak on request failure' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/tap: fix memory leak on IPC request' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'ipc: fix send error handling' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'ipc: harden message receive' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'ipc: handle more invalid parameter cases' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'event/dsw: fix capability flags' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/mlx5: fix comments mixing Rx and Tx' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'doc: fix interactive commands in testpmd guide' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'app/testpmd: fix help info for interactive commands' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/ring: fix coding style' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/ring: avoid hard-coded length' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/ring: use calloc style where appropriate' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/ring: check length of ring name' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/ring: fix return value check' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/kni: " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'app/testpmd: fix unintentional integer overflow' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/i40e: fix queue number check' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'test/bonding: fix MAC assignment for re-run' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/i40e: fix link speed for X722' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/mlx5: check Tx queue size overflow' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/mlx5: fix max number of queues for NEON Tx' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/tap: fix potential IPC buffer overrun' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/vmxnet3: add VLAN filter capability' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'net/netvsc: reset mbuf port on VF Rx' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'test: clean remaining trace of devargs autotest' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'eventdev: update references to removed function' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'hash: fix doc about thread/process safety' " Kevin Traynor
2019-05-08 16:02 ` [dpdk-stable] patch 'doc: fix broken link in LPM guide' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508160233.2648-5-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=stable@dpdk.org \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).