From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 36511A0096 for ; Wed, 8 May 2019 18:02:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BBB7374C; Wed, 8 May 2019 18:02:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B9EB84C74 for ; Wed, 8 May 2019 18:02:46 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 23B72307EA87; Wed, 8 May 2019 16:02:46 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 15ABC60C9F; Wed, 8 May 2019 16:02:44 +0000 (UTC) From: Kevin Traynor To: David Hunt Cc: Reshma Pattan , dpdk stable Date: Wed, 8 May 2019 17:02:03 +0100 Message-Id: <20190508160233.2648-6-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 08 May 2019 16:02:46 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/power: fix buffer overrun' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/695d45d68113f1a5ae3a18b3842fac329c3a7d69 Thanks. Kevin Traynor --- >From 695d45d68113f1a5ae3a18b3842fac329c3a7d69 Mon Sep 17 00:00:00 2001 From: David Hunt Date: Fri, 26 Apr 2019 09:42:09 +0100 Subject: [PATCH] examples/power: fix buffer overrun [ upstream commit 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db ] The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements, yet the code can attempt to look at the index at RTE_MAX_LCORE, which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to RTE_MAX_LCORE_FREQS. Coverity issue: 337660 Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host") Signed-off-by: David Hunt Acked-by: Reshma Pattan --- examples/vm_power_manager/power_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vm_power_manager/power_manager.c b/examples/vm_power_manager/power_manager.c index f9e8c0abd..318fb0255 100644 --- a/examples/vm_power_manager/power_manager.c +++ b/examples/vm_power_manager/power_manager.c @@ -158,5 +158,5 @@ power_manager_get_current_frequency(unsigned core_num) index = rte_power_get_freq(core_num); rte_spinlock_unlock(&global_core_freq_info[core_num].power_sl); - if (index >= POWER_MGR_MAX_CPUS) + if (index >= RTE_MAX_LCORE_FREQS) freq = 0; else -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:57.808861123 +0100 +++ 0006-examples-power-fix-buffer-overrun.patch 2019-05-08 16:33:57.360579813 +0100 @@ -1 +1 @@ -From 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db Mon Sep 17 00:00:00 2001 +From 695d45d68113f1a5ae3a18b3842fac329c3a7d69 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 3f1fc5f2cbc57ed719f9a1b24c8e450c5a95e8db ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 9553455be..9d4e587b0 100644 +index f9e8c0abd..318fb0255 100644 @@ -25 +26 @@ -@@ -144,5 +144,5 @@ power_manager_get_current_frequency(unsigned core_num) +@@ -158,5 +158,5 @@ power_manager_get_current_frequency(unsigned core_num) @@ -28 +29 @@ -- if (index >= RTE_MAX_LCORE) +- if (index >= POWER_MGR_MAX_CPUS)