From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 5DCF0A0AD9 for ; Wed, 8 May 2019 18:02:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52A9E378B; Wed, 8 May 2019 18:02:50 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7C5584C8D for ; Wed, 8 May 2019 18:02:49 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E1A8A859FC; Wed, 8 May 2019 16:02:48 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-210.ams2.redhat.com [10.36.117.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id F375060C82; Wed, 8 May 2019 16:02:47 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Rami Rosen , dpdk stable Date: Wed, 8 May 2019 17:02:05 +0100 Message-Id: <20190508160233.2648-8-ktraynor@redhat.com> In-Reply-To: <20190508160233.2648-1-ktraynor@redhat.com> References: <20190508160233.2648-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 08 May 2019 16:02:48 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: fix formatting of hotplug error message' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/14/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/4f5b343dae3812919e31e37cb5af2f70188f0d0e Thanks. Kevin Traynor --- >From 4f5b343dae3812919e31e37cb5af2f70188f0d0e Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 24 Apr 2019 09:46:19 -0700 Subject: [PATCH] eal: fix formatting of hotplug error message [ upstream commit 4e2fdf376011d2e2e274bf86167789aa4d41ae4a ] This message was missing newline, and should capitalize "Cannot" like all the others in this area. Fixes: ac9e4a17370f ("eal: support attach/detach shared device from secondary") Signed-off-by: Stephen Hemminger Acked-by: Rami Rosen --- lib/librte_eal/common/hotplug_mp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c index 9d610a8a2..7c3f38dba 100644 --- a/lib/librte_eal/common/hotplug_mp.c +++ b/lib/librte_eal/common/hotplug_mp.c @@ -362,5 +362,5 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) ret = rte_mp_request_sync(&mp_req, &mp_reply, &ts); if (ret || mp_reply.nb_received != 1) { - RTE_LOG(ERR, EAL, "cannot send request to primary"); + RTE_LOG(ERR, EAL, "Cannot send request to primary\n"); if (!ret) return -1; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-08 16:33:57.909426507 +0100 +++ 0008-eal-fix-formatting-of-hotplug-error-message.patch 2019-05-08 16:33:57.361579781 +0100 @@ -1 +1 @@ -From 4e2fdf376011d2e2e274bf86167789aa4d41ae4a Mon Sep 17 00:00:00 2001 +From 4f5b343dae3812919e31e37cb5af2f70188f0d0e Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4e2fdf376011d2e2e274bf86167789aa4d41ae4a ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 4052a5c7f..04616519c 100644 +index 9d610a8a2..7c3f38dba 100644 @@ -22 +23 @@ -@@ -377,5 +377,5 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req) +@@ -362,5 +362,5 @@ int eal_dev_hotplug_request_to_primary(struct eal_dev_mp_req *req)