* Re: [dpdk-stable] [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues [not found] <20190510094723.3627-1-mattias.ronnblom@ericsson.com> @ 2019-05-10 9:53 ` Mattias Rönnblom 2019-05-10 10:26 ` Kevin Traynor 0 siblings, 1 reply; 3+ messages in thread From: Mattias Rönnblom @ 2019-05-10 9:53 UTC (permalink / raw) To: dev; +Cc: Jerin Jacob, stefan.sundkvist, stable On 2019-05-10 11:47, Mattias Rönnblom wrote: > The scheduling type parameter is not applicable for single link > queues. DSW would, at the time of rte_event_queue_setup(), erroneously > verify that scheduling type was one of the supported types, and > returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED. > > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com> Adding stable@dpdk.org. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues 2019-05-10 9:53 ` [dpdk-stable] [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues Mattias Rönnblom @ 2019-05-10 10:26 ` Kevin Traynor 2019-05-10 12:18 ` [dpdk-stable] [PATCH v2] " Mattias Rönnblom 0 siblings, 1 reply; 3+ messages in thread From: Kevin Traynor @ 2019-05-10 10:26 UTC (permalink / raw) To: Mattias Rönnblom, dev; +Cc: Jerin Jacob, stefan.sundkvist, stable On 10/05/2019 10:53, Mattias Rönnblom wrote: > On 2019-05-10 11:47, Mattias Rönnblom wrote: >> The scheduling type parameter is not applicable for single link >> queues. DSW would, at the time of rte_event_queue_setup(), erroneously >> verify that scheduling type was one of the supported types, and >> returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED. >> >> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com> > > Adding stable@dpdk.org. > Please add it and a Fixes tag in the commit msg, so it won't be missed later, thanks. http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported ^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH v2] event/dsw: ignore scheduling type for single-link queues 2019-05-10 10:26 ` Kevin Traynor @ 2019-05-10 12:18 ` Mattias Rönnblom 0 siblings, 0 replies; 3+ messages in thread From: Mattias Rönnblom @ 2019-05-10 12:18 UTC (permalink / raw) To: dev; +Cc: Jerin Jacob, stefan.sundkvist, stable, Mattias Rönnblom The scheduling type parameter is not applicable for single link queues. DSW would, at the time of rte_event_queue_setup(), erroneously verify that scheduling type was one of the supported types, and returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED. Fixes: 4540ee9c68 ("event/dsw: add device and queue configuration") Cc: stable@dpdk.org Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com> --- drivers/event/dsw/dsw_evdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c index 4157d130c..9387d4149 100644 --- a/drivers/event/dsw/dsw_evdev.c +++ b/drivers/event/dsw/dsw_evdev.c @@ -102,9 +102,6 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, if (RTE_EVENT_QUEUE_CFG_ALL_TYPES & conf->event_queue_cfg) return -ENOTSUP; - if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED) - return -ENOTSUP; - /* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it * avoid the "fake" TYPE_PARALLEL flow_id assignment. Since * the queue will only have a single serving port, no @@ -113,8 +110,12 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, */ if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg) queue->schedule_type = RTE_SCHED_TYPE_ATOMIC; - else /* atomic or parallel */ + else { + if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED) + return -ENOTSUP; + /* atomic or parallel */ queue->schedule_type = conf->schedule_type; + } queue->num_serving_ports = 0; -- 2.17.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-10 12:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20190510094723.3627-1-mattias.ronnblom@ericsson.com> 2019-05-10 9:53 ` [dpdk-stable] [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for single-link queues Mattias Rönnblom 2019-05-10 10:26 ` Kevin Traynor 2019-05-10 12:18 ` [dpdk-stable] [PATCH v2] " Mattias Rönnblom
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).