From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 572CFA00E6 for ; Tue, 14 May 2019 16:44:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CA585B2A; Tue, 14 May 2019 16:44:54 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id DF7126833 for ; Tue, 14 May 2019 16:44:52 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8BC230BBEBF; Tue, 14 May 2019 14:44:47 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-124.ams2.redhat.com [10.36.116.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBED2608BB; Tue, 14 May 2019 14:44:46 +0000 (UTC) From: Kevin Traynor To: David Christensen Cc: Konstantin Ananyev , dpdk stable Date: Tue, 14 May 2019 15:43:55 +0100 Message-Id: <20190514144406.7526-11-ktraynor@redhat.com> In-Reply-To: <20190514144406.7526-1-ktraynor@redhat.com> References: <20190514144406.7526-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 14 May 2019 14:44:52 +0000 (UTC) Subject: [dpdk-stable] patch 'test/barrier: fix for Power CPUs' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/20/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/73fcd00b3a697668fe203a178d65e7029380c67b Thanks. Kevin Traynor --- >From 73fcd00b3a697668fe203a178d65e7029380c67b Mon Sep 17 00:00:00 2001 From: David Christensen Date: Wed, 8 May 2019 16:02:43 -0500 Subject: [PATCH] test/barrier: fix for Power CPUs [ upstream commit 2d119c3baac4409092d064d386deb33d8f61f90f ] The memory barrier test fails on IBM Power 9 systems. Add additional barriers to accommodate the weakly ordered model used on Power CPUs. Fixes: 93da5b59afc9 ("test: introduce memory barrier test case") Signed-off-by: David Christensen Acked-by: Konstantin Ananyev --- test/test/test_barrier.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/test_barrier.c b/test/test/test_barrier.c index ae37b1e5c..92f3d325f 100644 --- a/test/test/test_barrier.c +++ b/test/test/test_barrier.c @@ -93,4 +93,5 @@ plock_lock(struct plock *l, uint32_t self) l->flag[self] = 1; + rte_smp_wmb(); l->victim = self; @@ -99,4 +100,5 @@ plock_lock(struct plock *l, uint32_t self) while (l->flag[other] == 1 && l->victim == self) rte_pause(); + rte_smp_rmb(); } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-05-14 15:39:07.838812101 +0100 +++ 0011-test-barrier-fix-for-Power-CPUs.patch 2019-05-14 15:39:07.307558931 +0100 @@ -1 +1 @@ -From 2d119c3baac4409092d064d386deb33d8f61f90f Mon Sep 17 00:00:00 2001 +From 73fcd00b3a697668fe203a178d65e7029380c67b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2d119c3baac4409092d064d386deb33d8f61f90f ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -15 +16 @@ - app/test/test_barrier.c | 2 ++ + test/test/test_barrier.c | 2 ++ @@ -18,4 +19,4 @@ -diff --git a/app/test/test_barrier.c b/app/test/test_barrier.c -index a0b47042f..43b5f6232 100644 ---- a/app/test/test_barrier.c -+++ b/app/test/test_barrier.c +diff --git a/test/test/test_barrier.c b/test/test/test_barrier.c +index ae37b1e5c..92f3d325f 100644 +--- a/test/test/test_barrier.c ++++ b/test/test/test_barrier.c