patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: Gage Eads <gage.eads@intel.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'event/dsw: ignore scheduling type for single-link queues' has been queued to LTS release 18.11.2
Date: Tue, 14 May 2019 15:44:04 +0100	[thread overview]
Message-ID: <20190514144406.7526-20-ktraynor@redhat.com> (raw)
In-Reply-To: <20190514144406.7526-1-ktraynor@redhat.com>

Hi,

FYI, your patch has been queued to LTS release 18.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/20/19. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c8a8ccd7f1bfbe2696be4dbdb967aa4e4f65f3ce

Thanks.

Kevin Traynor

---
From c8a8ccd7f1bfbe2696be4dbdb967aa4e4f65f3ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Date: Fri, 10 May 2019 14:18:16 +0200
Subject: [PATCH] event/dsw: ignore scheduling type for single-link queues
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

[ upstream commit 7e192bdb0c55745a81e7f5e0eaf2b7a911aeadd4 ]

The scheduling type parameter is not applicable for single link
queues. DSW would, at the time of rte_event_queue_setup(), erroneously
verify that scheduling type was one of the supported types, and
returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED.

Fixes: 4540ee9c68 ("event/dsw: add device and queue configuration")

Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Gage Eads <gage.eads@intel.com>
---
 drivers/event/dsw/dsw_evdev.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 4157d130c..9387d4149 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -103,7 +103,4 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
 		return -ENOTSUP;
 
-	if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
-		return -ENOTSUP;
-
 	/* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it
 	 * avoid the "fake" TYPE_PARALLEL flow_id assignment. Since
@@ -114,6 +111,10 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
 	if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg)
 		queue->schedule_type = RTE_SCHED_TYPE_ATOMIC;
-	else /* atomic or parallel */
+	else {
+		if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
+			return -ENOTSUP;
+		/* atomic or parallel */
 		queue->schedule_type = conf->schedule_type;
+	}
 
 	queue->num_serving_ports = 0;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2019-05-14 15:39:08.265832781 +0100
+++ 0020-event-dsw-ignore-scheduling-type-for-single-link-que.patch	2019-05-14 15:39:07.322558631 +0100
@@ -1 +1 @@
-From 7e192bdb0c55745a81e7f5e0eaf2b7a911aeadd4 Mon Sep 17 00:00:00 2001
+From c8a8ccd7f1bfbe2696be4dbdb967aa4e4f65f3ce Mon Sep 17 00:00:00 2001
@@ -8,0 +9,2 @@
+[ upstream commit 7e192bdb0c55745a81e7f5e0eaf2b7a911aeadd4 ]
+
@@ -15 +16,0 @@
-Cc: stable@dpdk.org

  parent reply	other threads:[~2019-05-14 14:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 14:43 [dpdk-stable] patch 'net/mlx5: fix Multi-Packet RQ mempool name' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'net/mlx5: fix release of Rx queue object' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'doc: fix typo in mlx5 guide' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'ipc: unlock on failure' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'doc: fix typo in IPC guide' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'ipc: add warnings about not using IPC with memory API' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'ipc: add warnings about correct API usage' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'power: fix cache line alignment' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'test/barrier: fix typo in log' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'test/barrier: fix allocation check' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'test/barrier: fix for Power CPUs' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'hash: fix position returned in free slots' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'hash: fix total entries count' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix build error log' " Kevin Traynor
2019-05-14 14:43 ` [dpdk-stable] patch 'devtools: fix symbol name in check " Kevin Traynor
2019-05-14 14:44 ` [dpdk-stable] patch 'devtools: accept experimental symbol promotion' " Kevin Traynor
2019-05-14 14:44 ` [dpdk-stable] patch 'devtools: fix check of symbol added as stable API' " Kevin Traynor
2019-05-14 14:44 ` [dpdk-stable] patch 'doc: fix formatting in testpmd guide' " Kevin Traynor
2019-05-14 14:44 ` [dpdk-stable] patch 'eventdev: fix Rx adapter event flush' " Kevin Traynor
2019-05-14 14:44 ` Kevin Traynor [this message]
2019-05-14 14:44 ` [dpdk-stable] patch 'app/testpmd: fix offload flags after port config' " Kevin Traynor
2019-05-14 14:44 ` [dpdk-stable] patch 'doc: fix JSON interface for power sample' " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190514144406.7526-20-ktraynor@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=gage.eads@intel.com \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).