* [dpdk-stable] [PATCH v2] mem: ease init in a docker container [not found] <CAJFAV8xFNDWZ_q=ecu8u5KqApeW04rZuOi5ZG7yNKYGs7sKaBQ@mail.gmail.com> @ 2019-05-23 9:52 ` Nicolas Dichtel 2019-05-23 14:29 ` David Marchand 0 siblings, 1 reply; 3+ messages in thread From: Nicolas Dichtel @ 2019-05-23 9:52 UTC (permalink / raw) To: dev Cc: Anatoly Burakov, Nicolas Dichtel, stable, Olivier Matz, Didier Pallard move_pages() is only used to get the numa node id, but this function is not allowed by default in docker (it needs CAP_SYS_NICE and an update of the seccomp profile). get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in the default seccomp profile. Note that the returned value of move_pages() was not checked, thus some errors could be hidden (if the requested id was 0). Cc: stable@dpdk.org Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Reviewed-by: Olivier Matz <olivier.matz@6wind.com> Reviewed-by: Didier Pallard <didier.pallard@6wind.com> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> --- v2: add fixes tag + cc stable fix title prefix lib/librte_eal/linux/eal/eal_memalloc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c b/lib/librte_eal/linux/eal/eal_memalloc.c index 1e9ebb86dd1b..438faa0ab168 100644 --- a/lib/librte_eal/linux/eal/eal_memalloc.c +++ b/lib/librte_eal/linux/eal/eal_memalloc.c @@ -600,9 +600,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id, } #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES - move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0); - - if (cur_socket_id != socket_id) { + ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, + MPOL_F_NODE | MPOL_F_ADDR); + if (ret < 0) { + RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s\n", + __func__, strerror(errno)); + goto mapped; + } else if (cur_socket_id != socket_id) { RTE_LOG(DEBUG, EAL, "%s(): allocation happened on wrong socket (wanted %d, got %d)\n", __func__, socket_id, cur_socket_id); -- 2.21.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2] mem: ease init in a docker container 2019-05-23 9:52 ` [dpdk-stable] [PATCH v2] mem: ease init in a docker container Nicolas Dichtel @ 2019-05-23 14:29 ` David Marchand 2019-06-04 11:05 ` Thomas Monjalon 0 siblings, 1 reply; 3+ messages in thread From: David Marchand @ 2019-05-23 14:29 UTC (permalink / raw) To: Nicolas Dichtel Cc: dev, Anatoly Burakov, dpdk stable, Olivier Matz, Didier Pallard On Thu, May 23, 2019 at 11:53 AM Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote: > move_pages() is only used to get the numa node id, but this function > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of > the seccomp profile). > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in > the default seccomp profile. > > Note that the returned value of move_pages() was not checked, thus some > errors could be hidden (if the requested id was 0). > > Cc: stable@dpdk.org > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com> > Reviewed-by: Didier Pallard <didier.pallard@6wind.com> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > --- > > v2: add fixes tag + cc stable > fix title prefix > > lib/librte_eal/linux/eal/eal_memalloc.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/linux/eal/eal_memalloc.c > b/lib/librte_eal/linux/eal/eal_memalloc.c > index 1e9ebb86dd1b..438faa0ab168 100644 > --- a/lib/librte_eal/linux/eal/eal_memalloc.c > +++ b/lib/librte_eal/linux/eal/eal_memalloc.c > @@ -600,9 +600,13 @@ alloc_seg(struct rte_memseg *ms, void *addr, int > socket_id, > } > > #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > - move_pages(getpid(), 1, &addr, NULL, &cur_socket_id, 0); > - > - if (cur_socket_id != socket_id) { > + ret = get_mempolicy(&cur_socket_id, NULL, 0, addr, > + MPOL_F_NODE | MPOL_F_ADDR); > + if (ret < 0) { > + RTE_LOG(DEBUG, EAL, "%s(): get_mempolicy: %s\n", > + __func__, strerror(errno)); > + goto mapped; > + } else if (cur_socket_id != socket_id) { > RTE_LOG(DEBUG, EAL, > "%s(): allocation happened on wrong socket > (wanted %d, got %d)\n", > __func__, socket_id, cur_socket_id); > -- > 2.21.0 > > Reviewed-by: David Marchand <david.marchand@redhat.com> -- David Marchand ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH v2] mem: ease init in a docker container 2019-05-23 14:29 ` David Marchand @ 2019-06-04 11:05 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2019-06-04 11:05 UTC (permalink / raw) To: Nicolas Dichtel Cc: stable, David Marchand, dev, Anatoly Burakov, Olivier Matz, Didier Pallard 23/05/2019 16:29, David Marchand: > On Thu, May 23, 2019 at 11:53 AM Nicolas Dichtel <nicolas.dichtel@6wind.com> > wrote: > > > move_pages() is only used to get the numa node id, but this function > > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of > > the seccomp profile). > > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in > > the default seccomp profile. > > > > Note that the returned value of move_pages() was not checked, thus some > > errors could be hidden (if the requested id was 0). > > > > Cc: stable@dpdk.org > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> > > Reviewed-by: Olivier Matz <olivier.matz@6wind.com> > > Reviewed-by: Didier Pallard <didier.pallard@6wind.com> > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > Reviewed-by: David Marchand <david.marchand@redhat.com> Applied, thanks Nico ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-04 11:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAJFAV8xFNDWZ_q=ecu8u5KqApeW04rZuOi5ZG7yNKYGs7sKaBQ@mail.gmail.com>
2019-05-23 9:52 ` [dpdk-stable] [PATCH v2] mem: ease init in a docker container Nicolas Dichtel
2019-05-23 14:29 ` David Marchand
2019-06-04 11:05 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).