From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DBE1BA0096 for ; Tue, 4 Jun 2019 09:35:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A01C21B9CA; Tue, 4 Jun 2019 09:35:37 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D000A1B9CA; Tue, 4 Jun 2019 09:35:35 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 00:35:34 -0700 X-ExtLoop1: 1 Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by orsmga007.jf.intel.com with ESMTP; 04 Jun 2019 00:35:32 -0700 Date: Tue, 4 Jun 2019 15:26:46 +0800 From: Ye Xiaolong To: "Zhang, Tianfei" Cc: dev@dpdk.org, rosen.xu@intel.com, stable@dpdk.org, Zhang@dpdk.org Message-ID: <20190604072646.GB94383@intel.com> References: <20190604135148.21791-1-tianfei.zhang@intel.com> <20190604135148.21791-2-tianfei.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190604135148.21791-2-tianfei.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v1 2/2] raw/ifpga: fix logically dead code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 06/04, Zhang, Tianfei wrote: >add temporary variable in max10_reg_write(). > >Coverity issue: 337927 >Cc: stable@dpdk.org Missing a Fixes line? > >Signed-off-by: Zhang, Tianfei >--- > drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c >index f354ee4b6..3ff6575d7 100644 >--- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c >+++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c >@@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int *val) > > int max10_reg_write(unsigned int reg, unsigned int val) > { >+ unsigned int tmp = val; >+ > if (!g_max10) > return -ENODEV; > > return spi_transaction_write(g_max10->spi_tran_dev, >- reg, 4, (unsigned char *)&val); >+ reg, 4, (unsigned char *)&tmp); > } > > struct intel_max10_device * >@@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device *spi, > > /* set PKVL Polling manually in BBS */ > ret = max10_reg_write(PKVL_POLLING_CTRL, 0x3); >- if (ret) { >+ if (ret != 0) { > dev_err(dev, "%s set PKVL polling fail\n", __func__); > goto spi_tran_fail; > } >-- >2.17.1 >