From: Ye Xiaolong <xiaolong.ye@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"
Date: Mon, 17 Jun 2019 23:40:51 +0800 [thread overview]
Message-ID: <20190617154051.GE76301@intel.com> (raw)
In-Reply-To: <1560758082-3479-1-git-send-email-david.marchand@redhat.com>
On 06/17, David Marchand wrote:
>This check on Linux environment has been added at a time when we already
>had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
>It was then missed when converting to RTE_EXEC_ENV_LINUX.
>
>Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for vDPA")
>Fixes: 742bde12f3bd ("build/linux: rename macro from LINUXAPP to LINUX")
>Cc: stable@dpdk.org
>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
>If we backport this to 18.11, the fix is to switch to
>RTE_EXEC_ENV_LINUXAPP.
>
>---
> examples/vdpa/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/examples/vdpa/Makefile b/examples/vdpa/Makefile
>index 9d16d8e..ab2bbdf 100644
>--- a/examples/vdpa/Makefile
>+++ b/examples/vdpa/Makefile
>@@ -10,7 +10,7 @@ RTE_TARGET ?= $(notdir $(abspath $(dir $(firstword $(wildcard $(RTE_SDK)/*/.conf
>
> include $(RTE_SDK)/mk/rte.vars.mk
>
>-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
>+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUX),y)
> $(info This application can only operate in a linux environment, \
> please change the definition of the RTE_TARGET environment variable)
> all:
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2019-06-17 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 7:54 [dpdk-stable] " David Marchand
2019-06-17 8:51 ` Tiwei Bie
2019-06-17 15:40 ` Ye Xiaolong [this message]
2019-06-20 9:58 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617154051.GE76301@intel.com \
--to=xiaolong.ye@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).