From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4A878A0471 for ; Fri, 21 Jun 2019 18:52:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 425EB1D591; Fri, 21 Jun 2019 18:52:04 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8652F1D54F for ; Fri, 21 Jun 2019 18:52:02 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE1B530833BE; Fri, 21 Jun 2019 16:51:53 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-77.ams2.redhat.com [10.36.117.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C2D0860BE0; Fri, 21 Jun 2019 16:51:45 +0000 (UTC) From: Kevin Traynor To: Jerin Jacob Cc: Honnappa Nagarahalli , Aaron Conole , dpdk stable Date: Fri, 21 Jun 2019 17:46:12 +0100 Message-Id: <20190621164626.31219-28-ktraynor@redhat.com> In-Reply-To: <20190621164626.31219-1-ktraynor@redhat.com> References: <20190621164626.31219-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 21 Jun 2019 16:52:02 +0000 (UTC) Subject: [dpdk-stable] patch 'acl: fix build with some arm64 compiler' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/26/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/a8c67a4d4aeebea552a9dcf18b6b3d2d4610e8d9 Thanks. Kevin Traynor --- >From a8c67a4d4aeebea552a9dcf18b6b3d2d4610e8d9 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Tue, 11 Jun 2019 19:45:03 +0530 Subject: [PATCH] acl: fix build with some arm64 compiler [ upstream commit 557c5cbde374172c7140bc6a7cef2cc81e5a29dc ] Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot using vdupq_n_s32. lib/librte_acl/acl_run_neon.h: In function 'search_neon_4' lib/librte_acl/acl_run_neon.h:230:12: error: 'input' may be used uninitialized in this function int32x4_t input; Fixes: 34fa6c27c156 ("acl: add NEON optimization for ARMv8") Suggested-by: Honnappa Nagarahalli Signed-off-by: Jerin Jacob Acked-by: Aaron Conole --- lib/librte_acl/acl_run_neon.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_acl/acl_run_neon.h b/lib/librte_acl/acl_run_neon.h index 01b9766d8..b3196cd12 100644 --- a/lib/librte_acl/acl_run_neon.h +++ b/lib/librte_acl/acl_run_neon.h @@ -182,6 +182,6 @@ search_neon_8(const struct rte_acl_ctx *ctx, const uint8_t **data, while (flows.started > 0) { /* Gather 4 bytes of input data for each stream. */ - input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input0, 0); - input1 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 4), input1, 0); + input0 = vdupq_n_s32(GET_NEXT_4BYTES(parms, 0)); + input1 = vdupq_n_s32(GET_NEXT_4BYTES(parms, 4)); input0 = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input0, 1); @@ -243,5 +243,5 @@ search_neon_4(const struct rte_acl_ctx *ctx, const uint8_t **data, while (flows.started > 0) { /* Gather 4 bytes of input data for each stream. */ - input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 0), input, 0); + input = vdupq_n_s32(GET_NEXT_4BYTES(parms, 0)); input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 1), input, 1); input = vsetq_lane_s32(GET_NEXT_4BYTES(parms, 2), input, 2); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-21 17:22:13.196009270 +0100 +++ 0028-acl-fix-build-with-some-arm64-compiler.patch 2019-06-21 17:22:11.737518807 +0100 @@ -1 +1 @@ -From 557c5cbde374172c7140bc6a7cef2cc81e5a29dc Mon Sep 17 00:00:00 2001 +From a8c67a4d4aeebea552a9dcf18b6b3d2d4610e8d9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 557c5cbde374172c7140bc6a7cef2cc81e5a29dc ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org