From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9682EA046B for ; Mon, 24 Jun 2019 17:26:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E2281BEE4; Mon, 24 Jun 2019 17:26:00 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7689A1BEE4 for ; Mon, 24 Jun 2019 17:25:59 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAFD33082E64; Mon, 24 Jun 2019 15:25:58 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCEEB19C6A; Mon, 24 Jun 2019 15:25:57 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Ferruh Yigit , dpdk stable Date: Mon, 24 Jun 2019 16:24:34 +0100 Message-Id: <20190624152525.19349-10-ktraynor@redhat.com> In-Reply-To: <20190624152525.19349-1-ktraynor@redhat.com> References: <20190624152525.19349-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 24 Jun 2019 15:25:58 +0000 (UTC) Subject: [dpdk-stable] patch 'net/i40e: remove unnecessary cast' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/da6355f3035f70c6bd422ec22e8dfe8ee35867c5 Thanks. Kevin Traynor --- >From da6355f3035f70c6bd422ec22e8dfe8ee35867c5 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 29 May 2019 12:14:59 -0700 Subject: [PATCH] net/i40e: remove unnecessary cast [ upstream commit fc7a79b808eddd2b64bcda6d088f316f6e47a244 ] The device private pointer (dev_private) is of type void * therefore no cast is necessary in C. Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit --- drivers/net/i40e/i40e_ethdev.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index af5e844b3..d93cb00d4 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1210,9 +1210,7 @@ i40e_parse_latest_vec_handler(__rte_unused const char *key, void *opaque) { - struct i40e_adapter *ad; + struct i40e_adapter *ad = opaque; int use_latest_vec; - ad = (struct i40e_adapter *)opaque; - use_latest_vec = atoi(value); @@ -10828,6 +10826,5 @@ i40e_start_timecounters(struct rte_eth_dev *dev) { struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; + struct i40e_adapter *adapter = dev->data->dev_private; struct rte_eth_link link; uint32_t tsync_inc_l; @@ -10881,6 +10878,5 @@ static int i40e_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta) { - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; + struct i40e_adapter *adapter = dev->data->dev_private; adapter->systime_tc.nsec += delta; @@ -10895,6 +10891,5 @@ i40e_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts) { uint64_t ns; - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; + struct i40e_adapter *adapter = dev->data->dev_private; ns = rte_timespec_to_ns(ts); @@ -10912,6 +10907,5 @@ i40e_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts) { uint64_t ns, systime_cycles; - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; + struct i40e_adapter *adapter = dev->data->dev_private; systime_cycles = i40e_read_systime_cyclecounter(dev); @@ -10989,7 +10983,5 @@ i40e_timesync_read_rx_timestamp(struct rte_eth_dev *dev, { struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; - + struct i40e_adapter *adapter = dev->data->dev_private; uint32_t sync_status; uint32_t index = flags & 0x03; @@ -11013,7 +11005,5 @@ i40e_timesync_read_tx_timestamp(struct rte_eth_dev *dev, { struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); - struct i40e_adapter *adapter = - (struct i40e_adapter *)dev->data->dev_private; - + struct i40e_adapter *adapter = dev->data->dev_private; uint32_t sync_status; uint64_t tx_tstamp_cycles; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-24 16:18:55.602160044 +0100 +++ 0010-net-i40e-remove-unnecessary-cast.patch 2019-06-24 16:18:54.969432687 +0100 @@ -1 +1 @@ -From fc7a79b808eddd2b64bcda6d088f316f6e47a244 Mon Sep 17 00:00:00 2001 +From da6355f3035f70c6bd422ec22e8dfe8ee35867c5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fc7a79b808eddd2b64bcda6d088f316f6e47a244 ] + @@ -9,2 +10,0 @@ -Cc: stable@dpdk.org - @@ -18 +18 @@ -index 7fa9e1bf9..3cf2c1bfb 100644 +index af5e844b3..d93cb00d4 100644 @@ -21 +21 @@ -@@ -1212,9 +1212,7 @@ i40e_parse_latest_vec_handler(__rte_unused const char *key, +@@ -1210,9 +1210,7 @@ i40e_parse_latest_vec_handler(__rte_unused const char *key, @@ -32 +32 @@ -@@ -10844,6 +10842,5 @@ i40e_start_timecounters(struct rte_eth_dev *dev) +@@ -10828,6 +10826,5 @@ i40e_start_timecounters(struct rte_eth_dev *dev) @@ -40 +40 @@ -@@ -10897,6 +10894,5 @@ static int +@@ -10881,6 +10878,5 @@ static int @@ -48 +48 @@ -@@ -10911,6 +10907,5 @@ i40e_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts) +@@ -10895,6 +10891,5 @@ i40e_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts) @@ -56 +56 @@ -@@ -10928,6 +10923,5 @@ i40e_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts) +@@ -10912,6 +10907,5 @@ i40e_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts) @@ -64 +64 @@ -@@ -11005,7 +10999,5 @@ i40e_timesync_read_rx_timestamp(struct rte_eth_dev *dev, +@@ -10989,7 +10983,5 @@ i40e_timesync_read_rx_timestamp(struct rte_eth_dev *dev, @@ -73 +73 @@ -@@ -11029,7 +11021,5 @@ i40e_timesync_read_tx_timestamp(struct rte_eth_dev *dev, +@@ -11013,7 +11005,5 @@ i40e_timesync_read_tx_timestamp(struct rte_eth_dev *dev,