From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id F0A75A046B for ; Mon, 24 Jun 2019 17:27:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E542C1BEE7; Mon, 24 Jun 2019 17:27:36 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 14E241BE55 for ; Mon, 24 Jun 2019 17:27:35 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 898D0285B4; Mon, 24 Jun 2019 15:27:34 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-250.ams2.redhat.com [10.36.116.250]) by smtp.corp.redhat.com (Postfix) with ESMTP id B78EA19C69; Mon, 24 Jun 2019 15:27:33 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: dpdk stable Date: Mon, 24 Jun 2019 16:25:12 +0100 Message-Id: <20190624152525.19349-48-ktraynor@redhat.com> In-Reply-To: <20190624152525.19349-1-ktraynor@redhat.com> References: <20190624152525.19349-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 24 Jun 2019 15:27:34 +0000 (UTC) Subject: [dpdk-stable] patch 'net/netvsc: initialize VF spinlock' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/27/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/1b44d282d072c319047039a3932a36915acb202d Thanks. Kevin Traynor --- >From 1b44d282d072c319047039a3932a36915acb202d Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 6 Jun 2019 09:15:10 -0700 Subject: [PATCH] net/netvsc: initialize VF spinlock [ upstream commit 5e811a1a39e650aafc931306b0042837baac0450 ] The VF spinlock was never initialized. It works because it is in zmalloc'd memory and an unlocked lock on x86 is 0. But for good practice, all spinlock's should be initialized. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index fad209f21..66e158c72 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -734,4 +734,5 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev) hv->latency = HN_CHAN_LATENCY_NS; hv->max_queues = 1; + rte_spinlock_init(&hv->vf_lock); hv->vf_port = HN_INVALID_PORT; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-06-24 16:18:57.545365934 +0100 +++ 0048-net-netvsc-initialize-VF-spinlock.patch 2019-06-24 16:18:55.094429736 +0100 @@ -1 +1 @@ -From 5e811a1a39e650aafc931306b0042837baac0450 Mon Sep 17 00:00:00 2001 +From 1b44d282d072c319047039a3932a36915acb202d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 5e811a1a39e650aafc931306b0042837baac0450 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 9e7cf2df5..70352f0e1 100644 +index fad209f21..66e158c72 100644 @@ -22 +23 @@ -@@ -740,4 +740,5 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev) +@@ -734,4 +734,5 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)