From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E147AA046B for ; Fri, 28 Jun 2019 02:10:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9069628EE; Fri, 28 Jun 2019 02:10:53 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1E6D73DC for ; Fri, 28 Jun 2019 02:10:48 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id cl9so2148016plb.10 for ; Thu, 27 Jun 2019 17:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jJ7M/KRfwabjI6RtXL0Fx2bK3yDHDZmZVU/nk9Ce49I=; b=TjDsdoWEjhSdNh5FZNQiwDqm17kJdBWFHS5qEGwG6UwRUbtLuWugKNZkcRjGCUXzXX wXnPCgaycgdJzZnOZN+lAnphi2dTaplptMcaIUhlS5TcCdOfYwbJpe3WkscufNB4nTWH CFmXu4RKjQQiBVk7xzwmGAjA23IvYOcuUorCu8y9uUxyv17kkVhk5fRWe+EoGlJ+taW6 U2PHil/idJy47K7Yp2z6vXV8sk4byNoank5bc/LhsK4kwvLb9tdgn36Y4Z99uxpXCtnW /l1KsGFWOJWj586tAZUjYSiOmB9z0GyF5a0o8d7WVTgCOgG5PHzB7KiIQttzKQ+eBNV8 /H3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jJ7M/KRfwabjI6RtXL0Fx2bK3yDHDZmZVU/nk9Ce49I=; b=MYyxyliFNnXKnz/R+6d1m3vviXXsH4WFDaPgd41eoo9gfzuCdP8hSpPgHBk4Fb1NuD I6OsDP0DJ+d8zwHxgkdriwNGggsD4dYQjIYzRV3aPzZaG2XF7wjSpSXAOyTsEWD2IXJc m3RVGwnfQ5Gy84fJTOsm4ma1py22CX+HLTnvI5OkQRnlsNHd+TZYQHo8NfgnWnopm1+R H4r/f+nUdrAB3Hs5O7svrI5Ih75yJ3o3wpJtfRNSVQZ8O3deFGm9Vth66x1IhD+T3tZd n4xnV4QMb8cqTg/xAMWfbrUSLTp0brHVCjiSECooC81XRrp/RXgugv/NMb5T4VFukb1g DhSw== X-Gm-Message-State: APjAAAVWnqdzGQ5t85CCHt47YzMHdePkOhM+ymkQwO7c83gU13At8KV4 IVZIM6MV1Jny8zm2bmoq0wTwyg== X-Google-Smtp-Source: APXvYqxeMB+B8X0Nkb/ZMWZk1J9Sch08qkcysI+uQzGfUB70qExTnYrNQsrfXXXcUY21/sRWTT++2w== X-Received: by 2002:a17:902:1003:: with SMTP id b3mr7983218pla.172.1561680647709; Thu, 27 Jun 2019 17:10:47 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f7sm224494pfd.43.2019.06.27.17.10.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 27 Jun 2019 17:10:47 -0700 (PDT) Date: Thu, 27 Jun 2019 17:10:40 -0700 From: Stephen Hemminger To: Ivan Malov Cc: Olivier Matz , dev@dpdk.org, "Ananyev, Konstantin" , Andrew Rybchenko , Tomasz Kulasek , stable@dpdk.org Message-ID: <20190627171040.486aa756@hermes.lan> In-Reply-To: <20190627215202.794-1-ivan.malov@oktetlabs.ru> References: <20190529173337.31157-1-ivan.malov@oktetlabs.ru> <20190627215202.794-1-ivan.malov@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net: fix the way how L4 checksum choice is tested X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 28 Jun 2019 00:52:02 +0300 Ivan Malov wrote: > + /* > + * Initialise ipv4_hdr beforehand to mute false positive > + * compiler warnings about this variable being possibly used > + * uninitialised in L4 parsing branches below albeit it is clearly > + * initialised in IPv4 parsing branch prior L4-related code. > + */ Really, keep the verbosity in the commit log not the code. One line commit is enough.