From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 980E8A00E6 for ; Fri, 12 Jul 2019 03:37:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BCCD1B4B6; Fri, 12 Jul 2019 03:37:51 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 1484D2F42; Fri, 12 Jul 2019 03:37:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 18:37:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="168186284" Received: from map1.sh.intel.com ([10.67.111.138]) by fmsmga007.fm.intel.com with ESMTP; 11 Jul 2019 18:37:44 -0700 From: Qiming Yang To: dev@dpdk.org Cc: Qiming Yang , stable@dpdk.org Date: Fri, 12 Jul 2019 09:34:46 +0800 Message-Id: <20190712013446.121853-1-qiming.yang@intel.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-stable] [PATCH v2] net/ice: fix flow validation fail issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" The return value of function ice_flow_valid_attr should be non-zero. This patch fixed this issue. Fixes: d76116a4678f ("net/ice: add generic flow API") Cc: stable@dpdk.org Signed-off-by: Qiming Yang --- drivers/net/ice/ice_generic_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c index d5ff278..e6a2c4b 100644 --- a/drivers/net/ice/ice_generic_flow.c +++ b/drivers/net/ice/ice_generic_flow.c @@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev, rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, "Invalid queue ID for" - " ethertype_filter."); + " switch filter."); return -rte_errno; } break; @@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev, } ret = ice_flow_valid_attr(attr, error); - if (!ret) + if (ret) return ret; inset = ice_flow_valid_pattern(pattern, error); -- 2.7.4