From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qiming Yang <qiming.yang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix flow validation fail issue
Date: Fri, 12 Jul 2019 16:49:52 +0800 [thread overview]
Message-ID: <20190712084952.GA47519@intel.com> (raw)
In-Reply-To: <20190712013446.121853-1-qiming.yang@intel.com>
Hi, qiming
On 07/12, Qiming Yang wrote:
>The return value of function ice_flow_valid_attr should
>be non-zero. This patch fixed this issue.
>
Minor nit about the title, 'issue' is never needed after word 'fix', what about
net/ice: fix flow validation failure ?
And for the commit log, it's unclear to me, I think what you want to say is
function ice_flow_valid_attr will return a negative value on error, right?
>Fixes: d76116a4678f ("net/ice: add generic flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qiming Yang <qiming.yang@intel.com>
>---
> drivers/net/ice/ice_generic_flow.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
>index d5ff278..e6a2c4b 100644
>--- a/drivers/net/ice/ice_generic_flow.c
>+++ b/drivers/net/ice/ice_generic_flow.c
>@@ -549,7 +549,7 @@ static int ice_flow_valid_action(struct rte_eth_dev *dev,
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> actions, "Invalid queue ID for"
>- " ethertype_filter.");
>+ " switch filter.");
> return -rte_errno;
> }
> break;
>@@ -596,7 +596,7 @@ ice_flow_validate(struct rte_eth_dev *dev,
> }
>
> ret = ice_flow_valid_attr(attr, error);
>- if (!ret)
>+ if (ret)
> return ret;
>
> inset = ice_flow_valid_pattern(pattern, error);
>--
>2.7.4
>
For the patch,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
prev parent reply other threads:[~2019-07-12 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 1:34 [dpdk-stable] " Qiming Yang
2019-07-12 8:49 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712084952.GA47519@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).