From: Olivier Matz <olivier.matz@6wind.com>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, nd@arm.com, thomas@monjalon.net,
jerinj@marvell.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
Honnappa.Nagarahalli@arm.com, i.maximets@samsung.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Date: Tue, 16 Jul 2019 13:31:56 +0200 [thread overview]
Message-ID: <20190716113156.nhnirohjmzdbb4wl@platinum> (raw)
In-Reply-To: <20190716090121.6c4aa6u6vp3mhb2q@platinum>
On Tue, Jul 16, 2019 at 11:01:21AM +0200, Olivier Matz wrote:
> On Fri, Jul 12, 2019 at 11:54:36PM +0800, Gavin Hu wrote:
> > Currently, the flush is done by dequeuing the ring in a while loop. It is
> > much simpler to flush the queue by resetting the head and tail indices.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
Actually it's not a fix, it adds a new API.
Is the patch in hash library intended to be backported? If yes, as it
seems to be a performance optimization, you'll need to describe what
scenario you're fixing and what is the performance gain. If no, the Cc
stable can be removed.
Thanks
> >
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2019-07-16 11:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1552620686-10347-1-git-send-email-gavin.hu@arm.com>
[not found] ` <20181212062404.30243-1-gavin.hu@arm.com>
2018-12-12 6:24 ` [dpdk-stable] [PATCH v1 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
[not found] ` <20181212064733.1008-1-gavin.hu@arm.com>
2018-12-12 6:47 ` [dpdk-stable] [PATCH v2 " Gavin Hu
2018-12-12 10:15 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2018-12-12 19:28 ` Mattias Rönnblom
2019-03-15 3:31 ` [dpdk-stable] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-03-29 14:17 ` Olivier Matz
2019-07-04 14:42 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-12 9:32 ` Gavin Hu (Arm Technology China)
2019-07-12 9:53 ` Olivier Matz
2019-07-12 11:06 ` Gavin Hu (Arm Technology China)
2019-07-12 11:48 ` Olivier Matz
2019-07-12 15:07 ` Gavin Hu (Arm Technology China)
2019-07-12 15:40 ` Honnappa Nagarahalli
2019-07-12 16:01 ` Gavin Hu (Arm Technology China)
2019-07-16 8:47 ` [dpdk-stable] " Olivier Matz
2019-07-16 9:00 ` Olivier Matz
2019-03-15 3:31 ` [dpdk-stable] [PATCH v7 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-12 9:26 ` [dpdk-stable] [PATCH v8 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-12 9:26 ` [dpdk-stable] [PATCH v8 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-12 15:54 ` [dpdk-stable] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-16 9:01 ` Olivier Matz
2019-07-16 11:31 ` Olivier Matz [this message]
2019-07-16 14:03 ` Gavin Hu (Arm Technology China)
2019-07-16 15:06 ` Thomas Monjalon
2019-07-16 19:25 ` Gavin Hu (Arm Technology China)
2019-07-12 15:54 ` [dpdk-stable] [PATCH v9 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716113156.nhnirohjmzdbb4wl@platinum \
--to=olivier.matz@6wind.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=hemant.agrawal@nxp.com \
--cc=i.maximets@samsung.com \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=nipun.gupta@nxp.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).