From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2DA4A046B for ; Tue, 23 Jul 2019 03:03:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5D141BEF8; Tue, 23 Jul 2019 03:03:01 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 520921BF6E for ; Tue, 23 Jul 2019 03:03:00 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:02:58 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11Hff026580; Tue, 23 Jul 2019 04:02:56 +0300 From: Yongseok Koh To: David Marchand Cc: Andrew Rybchenko , Maxime Coquelin , Ferruh Yigit , dpdk stable Date: Mon, 22 Jul 2019 18:00:22 -0700 Message-Id: <20190723010115.6446-55-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: remove useless casts on statistics' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 3390fad3c1d75b4aba0d7584e333053e7985bad5 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 25 Mar 2019 09:51:45 +0100 Subject: [PATCH] app/testpmd: remove useless casts on statistics [ upstream commit 7718296d06916d0b2029763913944f0067a2d0dd ] Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit --- app/test-pmd/testpmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5db60c38e6..f8c76a6f60 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -988,7 +988,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" RX-packets: %-14"PRIu64" RX-dropped: %-14"PRIu64"RX-total: " "%-"PRIu64"\n", stats->ipackets, stats->imissed, - (uint64_t) (stats->ipackets + stats->imissed)); + stats->ipackets + stats->imissed); if (cur_fwd_eng == &csum_fwd_engine) printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64" \n", @@ -1001,13 +1001,13 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" TX-packets: %-14"PRIu64" TX-dropped: %-14"PRIu64"TX-total: " "%-"PRIu64"\n", stats->opackets, port->tx_dropped, - (uint64_t) (stats->opackets + port->tx_dropped)); + stats->opackets + port->tx_dropped); } else { printf(" RX-packets: %14"PRIu64" RX-dropped:%14"PRIu64" RX-total:" "%14"PRIu64"\n", stats->ipackets, stats->imissed, - (uint64_t) (stats->ipackets + stats->imissed)); + stats->ipackets + stats->imissed); if (cur_fwd_eng == &csum_fwd_engine) printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"PRIu64"\n", @@ -1021,7 +1021,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" TX-packets: %14"PRIu64" TX-dropped:%14"PRIu64" TX-total:" "%14"PRIu64"\n", stats->opackets, port->tx_dropped, - (uint64_t) (stats->opackets + port->tx_dropped)); + stats->opackets + port->tx_dropped); } #ifdef RTE_TEST_PMD_RECORD_BURST_STATS -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:09.465175013 -0700 +++ 0055-app-testpmd-remove-useless-casts-on-statistics.patch 2019-07-22 17:55:06.150471000 -0700 @@ -1,12 +1,13 @@ -From 7718296d06916d0b2029763913944f0067a2d0dd Mon Sep 17 00:00:00 2001 +From 3390fad3c1d75b4aba0d7584e333053e7985bad5 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Mon, 25 Mar 2019 09:51:45 +0100 Subject: [PATCH] app/testpmd: remove useless casts on statistics +[ upstream commit 7718296d06916d0b2029763913944f0067a2d0dd ] + Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") -Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko @@ -17,10 +18,10 @@ 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c -index 05a3dce49f..c78d524578 100644 +index 5db60c38e6..f8c76a6f60 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c -@@ -1376,7 +1376,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) +@@ -988,7 +988,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" RX-packets: %-14"PRIu64" RX-dropped: %-14"PRIu64"RX-total: " "%-"PRIu64"\n", stats->ipackets, stats->imissed, @@ -28,8 +29,8 @@ + stats->ipackets + stats->imissed); if (cur_fwd_eng == &csum_fwd_engine) - printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n", -@@ -1390,13 +1390,13 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) + printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64" \n", +@@ -1001,13 +1001,13 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" TX-packets: %-14"PRIu64" TX-dropped: %-14"PRIu64"TX-total: " "%-"PRIu64"\n", stats->opackets, port->tx_dropped, @@ -44,8 +45,8 @@ + stats->ipackets + stats->imissed); if (cur_fwd_eng == &csum_fwd_engine) - printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"PRIu64" Bad-outer-l4csum: %-14"PRIu64"\n", -@@ -1411,7 +1411,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) + printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"PRIu64"\n", +@@ -1021,7 +1021,7 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats) printf(" TX-packets: %14"PRIu64" TX-dropped:%14"PRIu64" TX-total:" "%14"PRIu64"\n", stats->opackets, port->tx_dropped,