From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11EC6A046B for ; Tue, 23 Jul 2019 03:04:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC8A31BFEB; Tue, 23 Jul 2019 03:04:01 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 074531BEF8 for ; Tue, 23 Jul 2019 03:03:59 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE2 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 23 Jul 2019 04:03:57 +0300 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x6N11HgG026580; Tue, 23 Jul 2019 04:03:56 +0300 From: Yongseok Koh To: Bruce Richardson Cc: dpdk stable Date: Mon, 22 Jul 2019 18:00:57 -0700 Message-Id: <20190723010115.6446-90-yskoh@mellanox.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190723010115.6446-1-yskoh@mellanox.com> References: <20190723010115.6446-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: fix warning with GCC 9' has been queued to LTS release 17.11.7 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 17.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objection by 07/27/19. So please shout if anyone has objection. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Yongseok --- >From 0f17f1cf19a5c6b95cc3d18f9fdde7ac4afb621c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 1 May 2019 20:50:11 +0100 Subject: [PATCH] net/ixgbe: fix warning with GCC 9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit e81b0569cc6855fb4d95635d0ae8a749da5d0aed ] Compiling on Fedora 30, we get the following warning, causing build failure when Werror flag is set: ../drivers/net/ixgbe/ixgbe_rxtx.c:2141:14: warning: ‘nmb’ may be used uninitialized in this function [-Wmaybe-uninitialized] 2141 | rxe->mbuf = nmb; | ~~~~~~~~~~^~~~~ Initializing the value to "NULL" fixes the issue. Fixes: 8eecb3295aed ("ixgbe: add LRO support") Signed-off-by: Bruce Richardson --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index ea6c038e00..a40b98567c 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -2058,7 +2058,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, struct ixgbe_rx_entry *next_rxe = NULL; struct rte_mbuf *first_seg; struct rte_mbuf *rxm; - struct rte_mbuf *nmb; + struct rte_mbuf *nmb = NULL; union ixgbe_adv_rx_desc rxd; uint16_t data_len; uint16_t next_id; -- 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-07-22 17:55:11.321399462 -0700 +++ 0090-net-ixgbe-fix-warning-with-GCC-9.patch 2019-07-22 17:55:06.431474000 -0700 @@ -1,4 +1,4 @@ -From e81b0569cc6855fb4d95635d0ae8a749da5d0aed Mon Sep 17 00:00:00 2001 +From 0f17f1cf19a5c6b95cc3d18f9fdde7ac4afb621c Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 1 May 2019 20:50:11 +0100 Subject: [PATCH] net/ixgbe: fix warning with GCC 9 @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit e81b0569cc6855fb4d95635d0ae8a749da5d0aed ] + Compiling on Fedora 30, we get the following warning, causing build failure when Werror flag is set: @@ -17,7 +19,6 @@ Initializing the value to "NULL" fixes the issue. Fixes: 8eecb3295aed ("ixgbe: add LRO support") -Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c -index e71d3c188a..1fbc754aea 100644 +index ea6c038e00..a40b98567c 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c -@@ -2029,7 +2029,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, +@@ -2058,7 +2058,7 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts, struct ixgbe_rx_entry *next_rxe = NULL; struct rte_mbuf *first_seg; struct rte_mbuf *rxm;