From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68829A00E6 for <public@inbox.dpdk.org>; Thu, 8 Aug 2019 14:27:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F4031BE1D; Thu, 8 Aug 2019 14:27:03 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by dpdk.org (Postfix) with ESMTP id ABD001BE1D; Thu, 8 Aug 2019 14:27:02 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 1D5A1200932; Thu, 8 Aug 2019 14:27:02 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 3C51F200030; Thu, 8 Aug 2019 14:26:58 +0200 (CEST) Received: from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id ED23340310; Thu, 8 Aug 2019 20:26:52 +0800 (SGT) From: Gagandeep Singh <g.singh@nxp.com> To: dev@dpdk.org, thomas@monjalon.net Cc: anatoly.burakov@intel.com, olivier.matz@6wind.com, arybchenko@solarflare.com, Gagandeep Singh <g.singh@nxp.com>, stable@dpdk.org, Nipun Gupta <nipun.gupta@nxp.com> Date: Thu, 8 Aug 2019 17:43:20 +0530 Message-Id: <20190808121320.12253-1-g.singh@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190807101204.21614-1-g.singh@nxp.com> References: <20190807101204.21614-1-g.singh@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-stable] [PATCH v2] eal: change max hugepage sizes to 4 for ARM platforms X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Sender: "stable" <stable-bounces@dpdk.org> ARM is supporting maximum 4 hugepage sizes (64K, 2M, 32M and 1G) when granule is 4KB since very long and DPDK support maximum 3 hugepage sizes. With all 4 hugepage sizes enabled, applications and some stacks like VPP which are working over DPDK and using "in-memory" eal option, or using separate mount points on ARM based platform, fails at huge page initialization, reporting error messages from eal: EAL: FATAL: Cannot get hugepage information. EAL: Cannot get hugepage information. EAL: Error - exiting with code: 1 This issue is visible on kernel 5.2 (stable rel), where kernel is by default creating directories for each supported hugepage size in /sys/kernel/mm/hugepages/ On earlier Stable Kernel LTR's, the directories visible in /sys/kernel/mm/hugepages/ were dependent upon what hugepage sizes are configured at boot time. This change increases the maximum supported mount points to 4 for ARM based platforms. Cc: stable@dpdk.org Signed-off-by: Gagandeep Singh <g.singh@nxp.com> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> --- Changes in V2: - restricted this change specific to ARM - commit message updated - stable added to cc lib/librte_eal/common/eal_internal_cfg.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h index edff09d07..a42f34923 100644 --- a/lib/librte_eal/common/eal_internal_cfg.h +++ b/lib/librte_eal/common/eal_internal_cfg.h @@ -15,7 +15,11 @@ #include "eal_thread.h" +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) +#define MAX_HUGEPAGE_SIZES 4 /**< support up to 4 page sizes */ +#else #define MAX_HUGEPAGE_SIZES 3 /**< support up to 3 page sizes */ +#endif /* * internal configuration structure for the number, size and -- 2.17.1