From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 322D9A046B for ; Fri, 23 Aug 2019 11:43:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 249C51BF4C; Fri, 23 Aug 2019 11:43:44 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CB3631BF4C for ; Fri, 23 Aug 2019 11:43:42 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21378106BB20; Fri, 23 Aug 2019 09:43:42 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB8815F9D3; Fri, 23 Aug 2019 09:43:40 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Rasesh Mody , =?UTF-8?q?Morten=20Br=C3=B8rup?= , dpdk stable Date: Fri, 23 Aug 2019 10:42:51 +0100 Message-Id: <20190823094336.12078-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Fri, 23 Aug 2019 09:43:42 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bnx2x: fix warnings from invalid assert' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/0956207da30f85d4f04c8e781891f28003ae332b Thanks. Kevin Traynor --- >From 0956207da30f85d4f04c8e781891f28003ae332b Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 19 Jun 2019 11:22:16 -0700 Subject: [PATCH] net/bnx2x: fix warnings from invalid assert MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 19927e56a853d9506d640a59fea7d2ec5ec2f208 ] This driver had a bogus assert which could never happen. This triggers "expression is always false warnings" with some compilers which causes build failure. Just remove it. Fixes: 6041aa619f9a ("net/bnx2x: fix poll link status") Signed-off-by: Stephen Hemminger Acked-by: Rasesh Mody Acked-by: Morten Brørup --- drivers/net/bnx2x/bnx2x_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index fa9d83154..cd0a6304c 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -150,5 +150,4 @@ static void bnx2x_periodic_start(void *param) PMD_DRV_LOG(ERR, sc, "Unable to start periodic" " timer rc %d", ret); - assert(false && "Unable to start periodic timer"); } } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-22 19:38:20.524316174 +0100 +++ 0001-net-bnx2x-fix-warnings-from-invalid-assert.patch 2019-08-22 19:38:20.389028024 +0100 @@ -1 +1 @@ -From 19927e56a853d9506d640a59fea7d2ec5ec2f208 Mon Sep 17 00:00:00 2001 +From 0956207da30f85d4f04c8e781891f28003ae332b Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 19927e56a853d9506d640a59fea7d2ec5ec2f208 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 45c6c363c..0ee35e4e4 100644 +index fa9d83154..cd0a6304c 100644 @@ -28 +29 @@ -@@ -151,5 +151,4 @@ static void bnx2x_periodic_start(void *param) +@@ -150,5 +150,4 @@ static void bnx2x_periodic_start(void *param)