From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D292A046B for ; Fri, 23 Aug 2019 11:44:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F1441BF9B; Fri, 23 Aug 2019 11:44:19 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 493B41BFA1 for ; Fri, 23 Aug 2019 11:44:18 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BEE37C014166; Fri, 23 Aug 2019 09:44:17 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFB9E5C226; Fri, 23 Aug 2019 09:44:16 +0000 (UTC) From: Kevin Traynor To: Konstantin Ananyev Cc: Michel Machado , dpdk stable Date: Fri, 23 Aug 2019 10:43:01 +0100 Message-Id: <20190823094336.12078-11-ktraynor@redhat.com> In-Reply-To: <20190823094336.12078-1-ktraynor@redhat.com> References: <20190823094336.12078-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 23 Aug 2019 09:44:17 +0000 (UTC) Subject: [dpdk-stable] patch 'bpf: fix check array size' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/d606af604d40a0da9cb44406a0068729e707cfd3 Thanks. Kevin Traynor --- >From d606af604d40a0da9cb44406a0068729e707cfd3 Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Fri, 21 Jun 2019 15:26:49 +0100 Subject: [PATCH] bpf: fix check array size [ upstream commit 28b2d3d112e2bde5264921d8feca89e2e5708a87 ] Array ins_chk in lib/librte_bpf/bpf_validate.c has 255 entries. So the instruction with opcode == 255 will reading beyond array boundaries. For more details please refer to: https://bugs.dpdk.org/show_bug.cgi?id=283 Fixes: 6e12ec4c4d6d ("bpf: add more checks") Reported-by: Michel Machado Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/bpf_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_bpf/bpf_validate.c b/lib/librte_bpf/bpf_validate.c index 83983efc4..d0e683b5b 100644 --- a/lib/librte_bpf/bpf_validate.c +++ b/lib/librte_bpf/bpf_validate.c @@ -1085,5 +1085,5 @@ eval_jcc(struct bpf_verifier *bvf, const struct ebpf_insn *ins) * validate parameters for each instruction type. */ -static const struct bpf_ins_check ins_chk[UINT8_MAX] = { +static const struct bpf_ins_check ins_chk[UINT8_MAX + 1] = { /* ALU IMM 32-bit instructions */ [(BPF_ALU | BPF_ADD | BPF_K)] = { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-22 19:38:21.191143492 +0100 +++ 0011-bpf-fix-check-array-size.patch 2019-08-22 19:38:20.403027690 +0100 @@ -1 +1 @@ -From 28b2d3d112e2bde5264921d8feca89e2e5708a87 Mon Sep 17 00:00:00 2001 +From d606af604d40a0da9cb44406a0068729e707cfd3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 28b2d3d112e2bde5264921d8feca89e2e5708a87 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org