From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 665DEA046B for ; Fri, 23 Aug 2019 11:45:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D7031BF9C; Fri, 23 Aug 2019 11:45:26 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 071911BF4C for ; Fri, 23 Aug 2019 11:45:25 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7C7D1A2F861; Fri, 23 Aug 2019 09:45:24 +0000 (UTC) Received: from rh.redhat.com (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7FD046313B; Fri, 23 Aug 2019 09:45:13 +0000 (UTC) From: Kevin Traynor To: Timothy Redaelli Cc: Luca Boccassi , David Marchand , dpdk stable Date: Fri, 23 Aug 2019 10:43:31 +0100 Message-Id: <20190823094336.12078-41-ktraynor@redhat.com> In-Reply-To: <20190823094336.12078-1-ktraynor@redhat.com> References: <20190823094336.12078-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Fri, 23 Aug 2019 09:45:24 +0000 (UTC) Subject: [dpdk-stable] patch 'usertools: fix refresh binding infos' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/28/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/b2826333d2631e1840a3465fb242efc3382c5dd9 Thanks. Kevin Traynor --- >From b2826333d2631e1840a3465fb242efc3382c5dd9 Mon Sep 17 00:00:00 2001 From: Timothy Redaelli Date: Fri, 31 May 2019 13:11:26 +0200 Subject: [PATCH] usertools: fix refresh binding infos [ upstream commit 93b93beb123d96e5acbbb24491c491bec47da60d ] Currently clear_data (dpdk-devbind.py) doesn't work as expected since "global devices" is missing and so "devices" is considered a local variable. This commit changes "clear_data" function in order to really clear devices by adding "global devices". Fixes: ea9f00f7289a ("usertools: refactor NIC and crypto binding details") Signed-off-by: Timothy Redaelli Acked-by: Luca Boccassi Reviewed-by: David Marchand --- usertools/dpdk-devbind.py | 1 + 1 file changed, 1 insertion(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index a9cd66a78..1c9c0187d 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -204,4 +204,5 @@ def get_pci_device_details(dev_id, probe_lspci): def clear_data(): '''This function clears any old data''' + global devices devices = {} -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-08-22 19:38:23.107944402 +0100 +++ 0041-usertools-fix-refresh-binding-infos.patch 2019-08-22 19:38:20.474025998 +0100 @@ -1 +1 @@ -From 93b93beb123d96e5acbbb24491c491bec47da60d Mon Sep 17 00:00:00 2001 +From b2826333d2631e1840a3465fb242efc3382c5dd9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 93b93beb123d96e5acbbb24491c491bec47da60d ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index 5c1cd3548..4791e5f48 100755 +index a9cd66a78..1c9c0187d 100755 @@ -27 +28 @@ -@@ -217,4 +217,5 @@ def get_pci_device_details(dev_id, probe_lspci): +@@ -204,4 +204,5 @@ def get_pci_device_details(dev_id, probe_lspci):