From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FC2BA00E6 for <public@inbox.dpdk.org>; Mon, 2 Sep 2019 08:06:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1D7E1BF05; Mon, 2 Sep 2019 08:06:02 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id ACEEA1BF05; Mon, 2 Sep 2019 08:06:01 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Sep 2019 23:06:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="183228486" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.71]) by fmsmga007.fm.intel.com with ESMTP; 01 Sep 2019 23:05:59 -0700 Date: Mon, 2 Sep 2019 14:03:33 +0800 From: Tiwei Bie <tiwei.bie@intel.com> To: Maxime Coquelin <maxime.coquelin@redhat.com> Cc: zhihong.wang@intel.com, amorenoz@redhat.com, xiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com, stable@dpdk.org Message-ID: <20190902060332.GA11681@___> References: <20190829080000.20806-1-maxime.coquelin@redhat.com> <20190829080000.20806-2-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190829080000.20806-2-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH 01/15] vhost: remove vhost kernel header inclusion X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Sender: "stable" <stable-bounces@dpdk.org> On Thu, Aug 29, 2019 at 09:59:46AM +0200, Maxime Coquelin wrote: > This is preliminary rework for virtio-vdpa driver, in > order to avoid conflicts with Virtio PMD headers. > > Generally, I think it is better not to include kernel > headers in RTE headers, especially in the case of Vhost > and Virtio which just re-use the kernel definitions, > and has no runtime dependencies. > > In order to not break IFC driver build, the vhost kernel > header is now included directly in the driver. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > drivers/net/ifc/ifcvf_vdpa.c | 1 + > lib/librte_vhost/rte_vdpa.h | 1 - > lib/librte_vhost/rte_vhost.h | 9 ++++----- > 3 files changed, 5 insertions(+), 6 deletions(-) Vhost examples need to be updated as well. Regards, Tiwei > > diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c > index 8de9ef199..40cb15ca8 100644