From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 15F38A00E6 for ; Mon, 2 Sep 2019 10:36:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D67091D505; Mon, 2 Sep 2019 10:36:39 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 992311BF15; Mon, 2 Sep 2019 10:36:36 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 01:36:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="357428684" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.5]) by orsmga005.jf.intel.com with ESMTP; 02 Sep 2019 01:36:33 -0700 Date: Mon, 2 Sep 2019 16:34:45 +0800 From: Ye Xiaolong To: Maxime Coquelin Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, amorenoz@redhat.com, xiao.w.wang@intel.com, dev@dpdk.org, jfreimann@redhat.com, stable@dpdk.org Message-ID: <20190902083445.GB1665@intel.com> References: <20190829080000.20806-1-maxime.coquelin@redhat.com> <20190829080000.20806-3-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829080000.20806-3-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [PATCH 02/15] vhost: configure vDPA as soon as the device is ready X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 08/29, Maxime Coquelin wrote: >There might not have any VHOST_USER_SET_VRING_CALL requests >sent once virtio device is ready. When it happens, the vDPA >device's dev_conf() callback may never be called. > >Fixes: 9f9014512822 ("vhost: configure vDPA device after set vring call message") >Cc: stable@dpdk.org >Cc: xiaolong.ye@intel.com > >Signed-off-by: Maxime Coquelin >--- > lib/librte_vhost/vhost_user.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >index 0b72648a5..b1ea80c52 100644 >--- a/lib/librte_vhost/vhost_user.c >+++ b/lib/librte_vhost/vhost_user.c >@@ -2112,8 +2112,7 @@ vhost_user_msg_handler(int vid, int fd) > did = dev->vdpa_dev_id; > vdpa_dev = rte_vdpa_get_device(did); > if (vdpa_dev && virtio_is_ready(dev) && >- !(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED) && >- msg.request.master == VHOST_USER_SET_VRING_CALL) { >+ !(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) { > if (vdpa_dev->ops->dev_conf) > vdpa_dev->ops->dev_conf(dev->vid); > dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED; >-- >2.21.0 > Reviewed-by: Xiaolong Ye