From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0CE0A2E1B for ; Thu, 5 Sep 2019 12:18:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98C321EF6F; Thu, 5 Sep 2019 12:18:49 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7D03A1EF6F for ; Thu, 5 Sep 2019 12:18:47 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E86BE8980FB; Thu, 5 Sep 2019 10:18:46 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id A79DC19C6A; Thu, 5 Sep 2019 10:18:45 +0000 (UTC) From: Kevin Traynor To: Sunil Kumar Kori Cc: Jerin Jacob , Konstantin Ananyev , dpdk stable Date: Thu, 5 Sep 2019 11:17:20 +0100 Message-Id: <20190905101754.21933-20-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Thu, 05 Sep 2019 10:18:46 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/ip_frag: remove Tx fast free offload flag' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783 Thanks. Kevin Traynor --- >From 9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Kori Date: Thu, 25 Jul 2019 13:54:10 +0530 Subject: [PATCH] examples/ip_frag: remove Tx fast free offload flag [ upstream commit ed553e3db4a84af0ddac0d898476333d61adb93a ] Application uses different pool to allocate direct and indirect mbufs which are further spliced together to consturct a fragmented packet and same is transmitted over the port which is configured with DEV_TX_OFFLOAD_MBUF_FAST_FREE enabled i.e. all segments must belong to the same pool. But constructed packet violates the conditions. So fixing DEV_TX_OFFLOAD_MBUF_FAST_FREE flag during device configuration. Fixes: fdb9eff67f0c ("examples/ip_fragmentation: convert to new offloads API") Signed-off-by: Sunil Kumar Kori Reviewed-by: Jerin Jacob Acked-by: Konstantin Ananyev --- examples/ip_fragmentation/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index ed78f0dd8..68d40c19a 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -922,7 +922,4 @@ main(int argc, char **argv) if (n_tx_queue > MAX_TX_QUEUE_PER_PORT) n_tx_queue = MAX_TX_QUEUE_PER_PORT; - if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) - local_port_conf.txmode.offloads |= - DEV_TX_OFFLOAD_MBUF_FAST_FREE; ret = rte_eth_dev_configure(portid, 1, (uint16_t)n_tx_queue, &local_port_conf); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:48.749916533 +0100 +++ 0020-examples-ip_frag-remove-Tx-fast-free-offload-flag.patch 2019-09-05 10:36:47.515700403 +0100 @@ -1 +1 @@ -From ed553e3db4a84af0ddac0d898476333d61adb93a Mon Sep 17 00:00:00 2001 +From 9fcd5f3deee26954f0c4b1dd6c3bbfad6f33d783 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ed553e3db4a84af0ddac0d898476333d61adb93a ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -27 +28 @@ -index 03be0c12e..324d60773 100644 +index ed78f0dd8..68d40c19a 100644 @@ -30 +31 @@ -@@ -940,7 +940,4 @@ main(int argc, char **argv) +@@ -922,7 +922,4 @@ main(int argc, char **argv)