From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28642A2E1B for ; Thu, 5 Sep 2019 12:18:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C5571EF75; Thu, 5 Sep 2019 12:18:17 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CE5AB1EF6E for ; Thu, 5 Sep 2019 12:18:15 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B2188830A; Thu, 5 Sep 2019 10:18:15 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23A5819C6A; Thu, 5 Sep 2019 10:18:13 +0000 (UTC) From: Kevin Traynor To: Adam Dybkowski Cc: dpdk stable Date: Thu, 5 Sep 2019 11:17:03 +0100 Message-Id: <20190905101754.21933-3-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 05 Sep 2019 10:18:15 +0000 (UTC) Subject: [dpdk-stable] patch 'compress/zlib: fix error handling' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/7dedc1b9ed87e912f66b1cbba3c3108bfa489342 Thanks. Kevin Traynor --- >From 7dedc1b9ed87e912f66b1cbba3c3108bfa489342 Mon Sep 17 00:00:00 2001 From: Adam Dybkowski Date: Wed, 24 Jul 2019 10:42:46 +0200 Subject: [PATCH] compress/zlib: fix error handling [ upstream commit ff53baa9cc676249d1c5c514755d77e453a99b51 ] Add missing return after setting the error status in case of invalid flush_flag in the operation. The issue was found by the coverity scan as the fin_flush variable, not initialized in such case, was used later in the flow. Coverity issue: 340859 Fixes: c7b436ec95fd ("compress/zlib: support burst enqueue/dequeue") Signed-off-by: Adam Dybkowski --- drivers/compress/zlib/zlib_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/compress/zlib/zlib_pmd.c b/drivers/compress/zlib/zlib_pmd.c index 5a4d47d4d..19f9200c2 100644 --- a/drivers/compress/zlib/zlib_pmd.c +++ b/drivers/compress/zlib/zlib_pmd.c @@ -31,4 +31,5 @@ process_zlib_deflate(struct rte_comp_op *op, z_stream *strm) op->status = RTE_COMP_OP_STATUS_INVALID_ARGS; ZLIB_PMD_ERR("Invalid flush value\n"); + return; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:47.713698241 +0100 +++ 0003-compress-zlib-fix-error-handling.patch 2019-09-05 10:36:47.439702222 +0100 @@ -1 +1 @@ -From ff53baa9cc676249d1c5c514755d77e453a99b51 Mon Sep 17 00:00:00 2001 +From 7dedc1b9ed87e912f66b1cbba3c3108bfa489342 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ff53baa9cc676249d1c5c514755d77e453a99b51 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org