From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43834A2E1B for ; Thu, 5 Sep 2019 12:19:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38CC41EF8B; Thu, 5 Sep 2019 12:19:13 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 28BDA1EF76 for ; Thu, 5 Sep 2019 12:19:11 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9752610C6976 for ; Thu, 5 Sep 2019 10:19:10 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9F7B19C6A; Thu, 5 Sep 2019 10:19:09 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: dpdk stable Date: Thu, 5 Sep 2019 11:17:33 +0100 Message-Id: <20190905101754.21933-33-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Thu, 05 Sep 2019 10:19:10 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: hide internal function' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/d1541e09feaf6c7a3198fd0e857b81ff1fa0010b Thanks. Kevin Traynor --- >From d1541e09feaf6c7a3198fd0e857b81ff1fa0010b Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 31 Jul 2019 14:07:33 +0200 Subject: [PATCH] eal: hide internal function [ upstream commit ba5d78da70dfeb23f92027cb4145066e5271c478 ] This function has never been used outside of this code unit. Mark it static and remove it from the eal internal header. Fixes: 9e29251b2afa ("eal: thread affinity API") Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/common/eal_thread.h | 11 ----------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/lib/librte_eal/common/eal_common_thread.c b/lib/librte_eal/common/eal_common_thread.c index 14f206c04..8388efb3e 100644 --- a/lib/librte_eal/common/eal_common_thread.c +++ b/lib/librte_eal/common/eal_common_thread.c @@ -39,5 +39,6 @@ rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role) } -int eal_cpuset_socket_id(rte_cpuset_t *cpusetp) +static int +eal_cpuset_socket_id(rte_cpuset_t *cpusetp) { unsigned cpu = 0; diff --git a/lib/librte_eal/common/eal_thread.h b/lib/librte_eal/common/eal_thread.h index 2d30b19b9..0d0bad06b 100644 --- a/lib/librte_eal/common/eal_thread.h +++ b/lib/librte_eal/common/eal_thread.h @@ -35,15 +35,4 @@ void eal_thread_init_master(unsigned lcore_id); unsigned eal_cpu_socket_id(unsigned cpu_id); -/** - * Get the NUMA socket id from cpuset. - * This function is private to EAL. - * - * @param cpusetp - * The point to a valid cpu set. - * @return - * socket_id or SOCKET_ID_ANY - */ -int eal_cpuset_socket_id(rte_cpuset_t *cpusetp); - /** * Default buffer size to use with eal_thread_dump_affinity() -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:49.510520881 +0100 +++ 0033-eal-hide-internal-function.patch 2019-09-05 10:36:47.530700043 +0100 @@ -1 +1 @@ -From ba5d78da70dfeb23f92027cb4145066e5271c478 Mon Sep 17 00:00:00 2001 +From d1541e09feaf6c7a3198fd0e857b81ff1fa0010b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit ba5d78da70dfeb23f92027cb4145066e5271c478 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index c91aba8f9..f9a8cf14d 100644 +index 14f206c04..8388efb3e 100644