From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 719A9A2E1B for ; Thu, 5 Sep 2019 12:19:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6844A1EF76; Thu, 5 Sep 2019 12:19:15 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 914251EFA4 for ; Thu, 5 Sep 2019 12:19:13 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0E62710C6978; Thu, 5 Sep 2019 10:19:13 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 236B819C6A; Thu, 5 Sep 2019 10:19:11 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: dpdk stable Date: Thu, 5 Sep 2019 11:17:35 +0100 Message-Id: <20190905101754.21933-35-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.65]); Thu, 05 Sep 2019 10:19:13 +0000 (UTC) Subject: [dpdk-stable] patch 'net/dpaa: fix build with 0 headroom' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/205ce8714392f69ed4ebc555ae755fcedfa47370 Thanks. Kevin Traynor --- >From 205ce8714392f69ed4ebc555ae755fcedfa47370 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Thu, 25 Jul 2019 16:36:43 +0530 Subject: [PATCH] net/dpaa: fix build with 0 headroom [ upstream commit 47854c180349c3d41690e60aea9458a864572389 ] When using RTE_PKTMBUF_HEADROOM as 0, dpaa driver throws compilation error error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" This patch change it into run-time check. Bugzilla ID: 335 Fixes: ff9e112d7870 ("net/dpaa: add NXP DPAA PMD driver skeleton") Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 10 ++++++++++ drivers/net/dpaa/dpaa_ethdev.h | 4 ---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index 5448a2ca7..5fbf152fa 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1461,4 +1461,14 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, PMD_INIT_FUNC_TRACE(); + if ((DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE) > + RTE_PKTMBUF_HEADROOM) { + DPAA_PMD_ERR( + "RTE_PKTMBUF_HEADROOM(%d) shall be > DPAA Annotation req(%d)", + RTE_PKTMBUF_HEADROOM, + DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE); + + return -1; + } + /* In case of secondary process, the device is already configured * and no further action is required, except portal initialization diff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h index 2fc723171..acbcaf6e6 100644 --- a/drivers/net/dpaa/dpaa_ethdev.h +++ b/drivers/net/dpaa/dpaa_ethdev.h @@ -22,8 +22,4 @@ #define DPAA_FD_PTA_SIZE 64 -#if (DPAA_MBUF_HW_ANNOTATION + DPAA_FD_PTA_SIZE) > RTE_PKTMBUF_HEADROOM -#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" -#endif - /* mbuf->seqn will be used to store event entry index for * driver specific usage. For parallel mode queues, invalid -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:49.639839340 +0100 +++ 0035-net-dpaa-fix-build-with-0-headroom.patch 2019-09-05 10:36:47.533699972 +0100 @@ -1 +1 @@ -From 47854c180349c3d41690e60aea9458a864572389 Mon Sep 17 00:00:00 2001 +From 205ce8714392f69ed4ebc555ae755fcedfa47370 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 47854c180349c3d41690e60aea9458a864572389 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index adc0bd5ac..7154fb9b4 100644 +index 5448a2ca7..5fbf152fa 100644 @@ -25 +26 @@ -@@ -1470,4 +1470,14 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, +@@ -1461,4 +1461,14 @@ rte_dpaa_probe(struct rte_dpaa_driver *dpaa_drv __rte_unused, @@ -41 +42 @@ -index 18bc7dfa8..f63a5f164 100644 +index 2fc723171..acbcaf6e6 100644 @@ -44 +45 @@ -@@ -23,8 +23,4 @@ +@@ -22,8 +22,4 @@