From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88647A2E1B for ; Thu, 5 Sep 2019 12:19:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D5411EF81; Thu, 5 Sep 2019 12:19:16 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D92481EF74 for ; Thu, 5 Sep 2019 12:19:14 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 52557641C9; Thu, 5 Sep 2019 10:19:14 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 701F219C6A; Thu, 5 Sep 2019 10:19:13 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: dpdk stable Date: Thu, 5 Sep 2019 11:17:36 +0100 Message-Id: <20190905101754.21933-36-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 05 Sep 2019 10:19:14 +0000 (UTC) Subject: [dpdk-stable] patch 'bus/fslmc: fix build with 0 headroom' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/c52e584dda405e167e14663a1755c5a5cfc66448 Thanks. Kevin Traynor --- >From c52e584dda405e167e14663a1755c5a5cfc66448 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Thu, 25 Jul 2019 16:36:44 +0530 Subject: [PATCH] bus/fslmc: fix build with 0 headroom [ upstream commit f4435e380d7cd51327051d2de3409ba83a2b690c ] When using RTE_PKTMBUF_HEADROOM as 0, dpaa driver throws compilation error error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" This patch change it into run-time check. Bugzilla ID: 335 Fixes: beb2a7865dda ("bus/fslmc: define hardware annotation area size") Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 4 ---- drivers/net/dpaa2/dpaa2_ethdev.c | 10 ++++++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index 2f52aca95..473f779a1 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h @@ -68,8 +68,4 @@ #define DPAA2_FD_PTA_SIZE 0 -#if (DPAA2_MBUF_HW_ANNOTATION + DPAA2_FD_PTA_SIZE) > RTE_PKTMBUF_HEADROOM -#error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" -#endif - /* we will re-use the HEADROOM for annotation in RX */ #define DPAA2_HW_BUF_RESERVE 0 diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 39f85ae7b..e3266085a 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2099,4 +2099,14 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, int diag; + if ((DPAA2_MBUF_HW_ANNOTATION + DPAA2_FD_PTA_SIZE) > + RTE_PKTMBUF_HEADROOM) { + DPAA2_PMD_ERR( + "RTE_PKTMBUF_HEADROOM(%d) shall be > DPAA2 Annotation req(%d)", + RTE_PKTMBUF_HEADROOM, + DPAA2_MBUF_HW_ANNOTATION + DPAA2_FD_PTA_SIZE); + + return -1; + } + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { eth_dev = rte_eth_dev_allocate(dpaa2_dev->device.name); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:49.700078866 +0100 +++ 0036-bus-fslmc-fix-build-with-0-headroom.patch 2019-09-05 10:36:47.536699900 +0100 @@ -1 +1 @@ -From f4435e380d7cd51327051d2de3409ba83a2b690c Mon Sep 17 00:00:00 2001 +From c52e584dda405e167e14663a1755c5a5cfc66448 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f4435e380d7cd51327051d2de3409ba83a2b690c ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ -index 8644761db..4bb6b26c7 100644 +index 2f52aca95..473f779a1 100644 @@ -25 +26 @@ -@@ -73,8 +73,4 @@ +@@ -68,8 +68,4 @@ @@ -35 +36 @@ -index 03f69599c..dd6a78f9f 100644 +index 39f85ae7b..e3266085a 100644 @@ -38 +39 @@ -@@ -2320,4 +2320,14 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv, +@@ -2099,4 +2099,14 @@ rte_dpaa2_probe(struct rte_dpaa2_driver *dpaa2_drv,