From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64BAAA2E1B for ; Thu, 5 Sep 2019 12:19:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5DBB01EF7B; Thu, 5 Sep 2019 12:19:28 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 11ECF1EF73 for ; Thu, 5 Sep 2019 12:19:26 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55005307D915; Thu, 5 Sep 2019 10:19:25 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE3E919C6A; Thu, 5 Sep 2019 10:19:23 +0000 (UTC) From: Kevin Traynor To: Konstantin Ananyev Cc: Michel Machado , dpdk stable Date: Thu, 5 Sep 2019 11:17:42 +0100 Message-Id: <20190905101754.21933-42-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 05 Sep 2019 10:19:25 +0000 (UTC) Subject: [dpdk-stable] patch 'examples/bpf: fix build' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/60954fdd1099995a1150ce8ef4bc3bf2a2d976b1 Thanks. Kevin Traynor --- >From 60954fdd1099995a1150ce8ef4bc3bf2a2d976b1 Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Tue, 30 Jul 2019 11:19:27 +0100 Subject: [PATCH] examples/bpf: fix build [ upstream commit 9a710863decb1cdb98efbdd5e11df3ebcfcc37b6 ] Example BPF programs t2.c, t3.c in folder examples/bpf are failing to compile with latest dpdk.org master. The reason is changes in some core DPDK header files, that causes now inclusion of x86 specific headers. To overcome the issue, minimize inclusion of DPDK header files into BPF source code. Bugzilla ID: 321 Fixes: 9dfc06c26a8b ("test/bpf: add samples") Reported-by: Michel Machado Suggested-by: Michel Machado Signed-off-by: Konstantin Ananyev --- test/bpf/mbuf.h | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/test/bpf/mbuf.h b/test/bpf/mbuf.h index f24f908d7..3059e7963 100644 --- a/test/bpf/mbuf.h +++ b/test/bpf/mbuf.h @@ -14,5 +14,4 @@ #include #include -#include #ifdef __cplusplus @@ -365,4 +364,21 @@ typedef struct { } rte_atomic16_t; +#define RTE_CACHE_LINE_MIN_SIZE 64 /**< Minimum Cache line size. */ + +/** + * Force minimum cache line alignment. + */ +#define __rte_cache_min_aligned __rte_aligned(RTE_CACHE_LINE_MIN_SIZE) + +/** + * IO virtual address type. + * When the physical addressing mode (IOVA as PA) is in use, + * the translation from an IO virtual address (IOVA) to a physical address + * is a direct mapping, i.e. the same value. + * Otherwise, in virtual mode (IOVA as VA), an IOMMU may do the translation. + */ +typedef uint64_t rte_iova_t; +#define RTE_BAD_IOVA ((rte_iova_t)-1) + /** * The generic rte_mbuf, containing a packet mbuf. @@ -378,5 +394,9 @@ struct rte_mbuf { * working on vector drivers easier. */ - phys_addr_t buf_physaddr __rte_aligned(sizeof(phys_addr_t)); + RTE_STD_C11 + union { + rte_iova_t buf_iova; + rte_iova_t buf_physaddr; /**< deprecated */ + } __rte_aligned(sizeof(rte_iova_t)); /* next 8 bytes are initialised on RX descriptor rearm */ -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:50.053726472 +0100 +++ 0042-examples-bpf-fix-build.patch 2019-09-05 10:36:47.546699660 +0100 @@ -1 +1 @@ -From 9a710863decb1cdb98efbdd5e11df3ebcfcc37b6 Mon Sep 17 00:00:00 2001 +From 60954fdd1099995a1150ce8ef4bc3bf2a2d976b1 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9a710863decb1cdb98efbdd5e11df3ebcfcc37b6 ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -22 +23 @@ - examples/bpf/mbuf.h | 24 ++++++++++++++++++++++-- + test/bpf/mbuf.h | 24 ++++++++++++++++++++++-- @@ -25,4 +26,4 @@ -diff --git a/examples/bpf/mbuf.h b/examples/bpf/mbuf.h -index b623d8694..e41c3d26e 100644 ---- a/examples/bpf/mbuf.h -+++ b/examples/bpf/mbuf.h +diff --git a/test/bpf/mbuf.h b/test/bpf/mbuf.h +index f24f908d7..3059e7963 100644 +--- a/test/bpf/mbuf.h ++++ b/test/bpf/mbuf.h