From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F166A2E1B for ; Thu, 5 Sep 2019 12:19:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 837951EF87; Thu, 5 Sep 2019 12:19:40 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C60A61EFAC for ; Thu, 5 Sep 2019 12:19:38 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3F722308213F; Thu, 5 Sep 2019 10:19:38 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2ECFA19C77; Thu, 5 Sep 2019 10:19:36 +0000 (UTC) From: Kevin Traynor To: Amit Gupta Cc: Jerin Jacob , dpdk stable Date: Thu, 5 Sep 2019 11:17:51 +0100 Message-Id: <20190905101754.21933-51-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 05 Sep 2019 10:19:38 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: fix latency stats deinit on signal' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/62aa226ee8102543cbd8c6d354924aaf52aacfdb Thanks. Kevin Traynor --- >From 62aa226ee8102543cbd8c6d354924aaf52aacfdb Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Wed, 7 Aug 2019 18:42:09 +0530 Subject: [PATCH] app/testpmd: fix latency stats deinit on signal [ upstream commit 8b36297d15f90265b50fae211157dff573513359 ] On receiving signal, testpmd showing warning as "LATENCY_STATS: failed to remove Rx/Tx callback" because rte_latencystats_uninit is called without checking if latencystats is enabled or not. After this fix, rte_latencystats_uninit will be called only if latencystats is enabled. Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation") Signed-off-by: Amit Gupta Acked-by: Jerin Jacob Tested-by: Jerin Jacob --- app/test-pmd/testpmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 41283b481..83b5e42a3 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3079,5 +3079,6 @@ signal_handler(int signum) #endif #ifdef RTE_LIBRTE_LATENCY_STATS - rte_latencystats_uninit(); + if (latencystats_enabled != 0) + rte_latencystats_uninit(); #endif force_quit(); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:50.588290621 +0100 +++ 0051-app-testpmd-fix-latency-stats-deinit-on-signal.patch 2019-09-05 10:36:47.563699253 +0100 @@ -1 +1 @@ -From 8b36297d15f90265b50fae211157dff573513359 Mon Sep 17 00:00:00 2001 +From 62aa226ee8102543cbd8c6d354924aaf52aacfdb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8b36297d15f90265b50fae211157dff573513359 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index a461cef18..e8e2a39b6 100644 +index 41283b481..83b5e42a3 100644 @@ -28 +29 @@ -@@ -3213,5 +3213,6 @@ signal_handler(int signum) +@@ -3079,5 +3079,6 @@ signal_handler(int signum)