From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBDA7A2E1B for ; Thu, 5 Sep 2019 12:19:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3CBD1EF74; Thu, 5 Sep 2019 12:19:43 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id BF4971EF94 for ; Thu, 5 Sep 2019 12:19:41 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38496307D923; Thu, 5 Sep 2019 10:19:41 +0000 (UTC) Received: from rh.redhat.com (ovpn-117-52.ams2.redhat.com [10.36.117.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A23019C6A; Thu, 5 Sep 2019 10:19:39 +0000 (UTC) From: Kevin Traynor To: Gagandeep Singh Cc: Nipun Gupta , dpdk stable Date: Thu, 5 Sep 2019 11:17:53 +0100 Message-Id: <20190905101754.21933-53-ktraynor@redhat.com> In-Reply-To: <20190905101754.21933-1-ktraynor@redhat.com> References: <20190905101754.21933-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 05 Sep 2019 10:19:41 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: increase maximum different hugepage sizes on Arm' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/12/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/8cc0dde788e684eec6f9f0454f4c019071242b47 Thanks. Kevin Traynor --- >From 8cc0dde788e684eec6f9f0454f4c019071242b47 Mon Sep 17 00:00:00 2001 From: Gagandeep Singh Date: Thu, 8 Aug 2019 17:43:20 +0530 Subject: [PATCH] eal: increase maximum different hugepage sizes on Arm [ upstream commit 47caefc163b884ed1911c6eec74d329d63ee46c5 ] ARM is supporting maximum 4 hugepage sizes (64K, 2M, 32M and 1G) when granule is 4KB since very long and DPDK support maximum 3 hugepage sizes. With all 4 hugepage sizes enabled, applications and some stacks like VPP which are working over DPDK and using "in-memory" eal option, or using separate mount points on ARM based platform, fails at huge page initialization, reporting error messages from eal: EAL: FATAL: Cannot get hugepage information. EAL: Cannot get hugepage information. EAL: Error - exiting with code: 1 This issue is originated from Linux 5.0 (a21b0b78eaf7 "arm64: hugetlb: Register hugepages during arch init") where kernel is by default creating directories for each supported hugepage size in /sys/kernel/mm/hugepages/ On earlier Stable Kernel LTR's, the directories visible in /sys/kernel/mm/hugepages/ were dependent upon what hugepage sizes are configured at boot time. This change increases the maximum supported hugepage sizes to 4 for ARM based platforms. Signed-off-by: Gagandeep Singh Signed-off-by: Nipun Gupta --- lib/librte_eal/common/eal_internal_cfg.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h index 189d4f5b2..ae92ec29b 100644 --- a/lib/librte_eal/common/eal_internal_cfg.h +++ b/lib/librte_eal/common/eal_internal_cfg.h @@ -16,5 +16,9 @@ #include "eal_thread.h" +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) +#define MAX_HUGEPAGE_SIZES 4 /**< support up to 4 page sizes */ +#else #define MAX_HUGEPAGE_SIZES 3 /**< support up to 3 page sizes */ +#endif /* -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2019-09-05 10:36:50.718012698 +0100 +++ 0053-eal-increase-maximum-different-hugepage-sizes-on-Arm.patch 2019-09-05 10:36:47.568699134 +0100 @@ -1 +1 @@ -From 47caefc163b884ed1911c6eec74d329d63ee46c5 Mon Sep 17 00:00:00 2001 +From 8cc0dde788e684eec6f9f0454f4c019071242b47 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 47caefc163b884ed1911c6eec74d329d63ee46c5 ] + @@ -32,2 +33,0 @@ -Cc: stable@dpdk.org - @@ -41 +41 @@ -index edff09d07..a42f34923 100644 +index 189d4f5b2..ae92ec29b 100644