From: Ye Xiaolong <xiaolong.ye@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Loftus, Ciara" <ciara.loftus@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: Re: [dpdk-stable] [PATCH] net/af_xdp: fix Tx halt when no recv packets
Date: Tue, 10 Sep 2019 21:53:47 +0800 [thread overview]
Message-ID: <20190910135347.GD6732@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061153D93589@SHSMSX105.ccr.corp.intel.com>
On 09/10, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Ye, Xiaolong
>> Sent: Tuesday, September 10, 2019 12:13 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Loftus, Ciara
>> <ciara.loftus@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: [PATCH] net/af_xdp: fix Tx halt when no recv packets
>>
>> The kernel only consumes Tx packets if we have some Rx traffic on specified
>> queue or we have called send(). So we need to issue a send() even when the
>> allocation fails so that kernel will start to consume packets again.
>
>So "allocation fails" means " xsk_ring_prod__reserve" fail right?
Yes.
>I don't understand when xsk_ring_prod__needs_wakeup is true why kernel will stop Tx packet at this situation
>would you share more insight?
Actually, the fail case is xsk_ring_prod__needs_wakeup is false, then we can't
issue a send() when xsk_ring_prod__reserve fails.
Thanks,
Xiaolong
>
>Thanks
>Qi
>
>>
>> Commit 45bba02c95b0 ("net/af_xdp: support need wakeup feature") breaks
>> above rule by adding some condition to send, this patch fixes it while still
>> keeps the need_wakeup feature for Tx.
>>
>> Fixes: 45bba02c95b0 ("net/af_xdp: support need wakeup feature")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>> drivers/net/af_xdp/rte_eth_af_xdp.c | 28 ++++++++++++++--------------
>> 1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index 41ed5b2af..e496e9aaa 100644
>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> @@ -286,19 +286,16 @@ kick_tx(struct pkt_tx_queue *txq) {
>> struct xsk_umem_info *umem = txq->pair->umem;
>>
>> -#if defined(XDP_USE_NEED_WAKEUP)
>> - if (xsk_ring_prod__needs_wakeup(&txq->tx))
>> -#endif
>> - while (send(xsk_socket__fd(txq->pair->xsk), NULL,
>> - 0, MSG_DONTWAIT) < 0) {
>> - /* some thing unexpected */
>> - if (errno != EBUSY && errno != EAGAIN && errno != EINTR)
>> - break;
>> -
>> - /* pull from completion queue to leave more space */
>> - if (errno == EAGAIN)
>> - pull_umem_cq(umem, ETH_AF_XDP_TX_BATCH_SIZE);
>> - }
>> + while (send(xsk_socket__fd(txq->pair->xsk), NULL,
>> + 0, MSG_DONTWAIT) < 0) {
>> + /* some thing unexpected */
>> + if (errno != EBUSY && errno != EAGAIN && errno != EINTR)
>> + break;
>> +
>> + /* pull from completion queue to leave more space */
>> + if (errno == EAGAIN)
>> + pull_umem_cq(umem, ETH_AF_XDP_TX_BATCH_SIZE);
>> + }
>> pull_umem_cq(umem, ETH_AF_XDP_TX_BATCH_SIZE); }
>>
>> @@ -367,7 +364,10 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf
>> **bufs, uint16_t nb_pkts)
>>
>> xsk_ring_prod__submit(&txq->tx, nb_pkts);
>>
>> - kick_tx(txq);
>> +#if defined(XDP_USE_NEED_WAKEUP)
>> + if (xsk_ring_prod__needs_wakeup(&txq->tx))
>> +#endif
>> + kick_tx(txq);
>>
>> txq->stats.tx_pkts += nb_pkts;
>> txq->stats.tx_bytes += tx_bytes;
>> --
>> 2.17.1
>
next prev parent reply other threads:[~2019-09-10 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 16:12 Xiaolong Ye
2019-09-10 4:14 ` Zhang, Qi Z
2019-09-10 13:53 ` Ye Xiaolong [this message]
2019-09-10 14:41 ` Zhang, Qi Z
2019-09-10 15:09 ` Ye Xiaolong
2019-09-11 2:05 ` Zhang, Qi Z
2019-09-11 12:56 ` Ye Xiaolong
2019-09-11 23:30 ` Zhang, Qi Z
2019-09-11 0:12 ` Zhang, Qi Z
2019-09-17 9:13 ` Loftus, Ciara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910135347.GD6732@intel.com \
--to=xiaolong.ye@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).