From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 333D6A317C
for <public@inbox.dpdk.org>; Thu, 17 Oct 2019 19:37:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id F15711E8E1;
Thu, 17 Oct 2019 19:37:25 +0200 (CEST)
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id AADCE1E882
for <stable@dpdk.org>; Thu, 17 Oct 2019 19:37:22 +0200 (CEST)
Received: by mail-pg1-f196.google.com with SMTP id e13so1747975pga.7
for <stable@dpdk.org>; Thu, 17 Oct 2019 10:37:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=MQ3ozm9r0pnW8cq5PWyrdfi1nYk4fc+hIiTU+++OL8g=;
b=usJfWjD+BiE0qAbNvgn4CwIN2tYmDHeEcDQV9nwPO4sqxo5s7b73Vc++12vRzBkGY9
KGpaN6ABhWG5gmjCgMlOm8K0D3DULeFEjVzHCIgusxOmXNcxU8HDTX2iOtXCTD6kIRhn
asieEzwpTfmjsmWWhG+nzyLAMHiOuxIc7PIi0QU2gEsYZlpOJ6N1ip5KnR5kvRtQ2rF4
+WwTWgKqF//Gz+4tRoAh0KdEdC5abCMBz6tNh6YhU5s2CwLyvzakY847Q3VzFDlCu7wU
O3fXu+NYxT8kbuoD2Vac557TvGLPHb2kr8aS71y2JvxnKebeAMusd9FLXuOZwWS3zTaN
J7Qw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=MQ3ozm9r0pnW8cq5PWyrdfi1nYk4fc+hIiTU+++OL8g=;
b=eZ/MvsJtqEkTbGU9Zk1EduuBc1hUynhkFjRTwYRQermkCnUBsG5JNBrZfRDKa+c+Hg
RVmpp/pifsXXT3RWXfFczmR0GtDSQM0zwmEPWplvxPkzMz1QZ8TA491xf8X5IfqloEJc
qx6GAIyfHJ3JoJTc4Z4ZrvhkD97+8/HBfZDnwso0QWvoN0gf5wkr1uW8DogpCnjSlx20
DOhVNKIzdwJPjFdaZCAkUww0s1iFPfXvbVDeLfjysAdbXTNPame3vRBEmKJD1hKjgK8g
62OUiDL+rJjNZYcNrlkVQQY4sPn3pxCmP86sT98bydTMtiC/UypMrLVPJen+TZ0yV3zk
mD6A==
X-Gm-Message-State: APjAAAUVUTKvGBIxol1v8jXPNmCPR3W9AUqLYPCYRWXn6JYrY/g2EwEq
cxwRczRwmheW0hL8vB3Jzi3fAA==
X-Google-Smtp-Source: APXvYqxqxGDk+xPMe+nzt+IH8/qg0r2j2FaC0xmHNTImfOiY4BHhCZ8aB39bV2O0mlhVu6+vNI6Dtg==
X-Received: by 2002:aa7:908b:: with SMTP id i11mr1524745pfa.140.1571333841686;
Thu, 17 Oct 2019 10:37:21 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id y144sm3831513pfb.188.2019.10.17.10.37.21
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 17 Oct 2019 10:37:21 -0700 (PDT)
Date: Thu, 17 Oct 2019 10:37:15 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Robin Jarry <robin.jarry@6wind.com>
Cc: Kevin Laatz <kevin.laatz@intel.com>, dev@dpdk.org, Andrius Sirvys
<andrius.sirvys@intel.com>, Ciara Power <ciara.power@intel.com>, Reshma
Pattan <reshma.pattan@intel.com>, stable@dpdk.org
Message-ID: <20191017103715.4ac27fce@hermes.lan>
In-Reply-To: <20191017173212.1038-1-robin.jarry@6wind.com>
References: <20191017173212.1038-1-robin.jarry@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] usertools: fix py3 syntax
errors with dpdk-telemetry-client.py
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On Thu, 17 Oct 2019 19:32:12 +0200
Robin Jarry <robin.jarry@6wind.com> wrote:
> When running the dpdk-telemetry-client.py with python 3, we get the
> following syntax errors:
>
> File "usertools/dpdk-telemetry-client.py", line 70
> print "\nResponse: \n", str(data)
> ^
> SyntaxError: invalid syntax
>
> File "usertools/dpdk-telemetry-client.py", line 93
> print "\nResponse: \n", str(data)
> ^
> SyntaxError: invalid syntax
>
> File "usertools/dpdk-telemetry-client.py", line 111
> file_path = sys.argv[1]
> ^
> TabError: inconsistent use of tabs and spaces in indentation
>
> Import print_function from __future__ and add parentheses where missing.
> Also, use spaces for indentation everywhere.
>
> Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
> Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
> Fixes: 4080e46c8078 ("telemetry: support global metrics")
> Cc: Andrius Sirvys <andrius.sirvys@intel.com>
> Cc: Ciara Power <ciara.power@intel.com>
> Cc: Kevin Laatz <kevin.laatz@intel.com>
> Cc: Reshma Pattan <reshma.pattan@intel.com>
> Cc: stable@dpdk.org
> Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>