From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Tianfei zhang <tianfei.zhang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check
Date: Fri, 25 Oct 2019 10:40:31 +0800 [thread overview]
Message-ID: <20191025024031.GD2504@intel.com> (raw)
In-Reply-To: <20190917222459.19097-1-tianfei.zhang@intel.com>
On 09/18, Tianfei zhang wrote:
>Add pointer null check before dereference.
>
>Coverity issue: 344976
>Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status")
>Cc: stable@dpdk.org
>
>Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
>---
> drivers/raw/ifpga/base/opae_eth_group.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c
>index d189dd578..be28954e0 100644
>--- a/drivers/raw/ifpga/base/opae_eth_group.c
>+++ b/drivers/raw/ifpga/base/opae_eth_group.c
>@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base)
>
> void eth_group_release(struct eth_group_device *dev)
> {
>- eth_group_hw_uinit(dev);
>-
> if (dev) {
>+ eth_group_hw_uinit(dev);
> dev->status = ETH_GROUP_DEV_NOUSED;
> opae_free(dev);
> }
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
next prev parent reply other threads:[~2019-10-25 2:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 22:24 [dpdk-stable] " Tianfei zhang
2019-10-24 19:22 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-10-25 1:05 ` Xu, Rosen
2019-10-25 2:40 ` Ye Xiaolong [this message]
2019-10-25 10:29 ` Ferruh Yigit
2019-10-25 11:47 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025024031.GD2504@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).