* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size
2019-10-28 15:54 ` [dpdk-stable] [PATCH v2] net/ice: fix setting max frame size Min JiaqiX
@ 2019-10-28 8:46 ` Ye Xiaolong
2019-10-29 2:05 ` Ye Xiaolong
2019-10-29 12:54 ` [dpdk-stable] [PATCH v3] " Min JiaqiX
1 sibling, 1 reply; 11+ messages in thread
From: Ye Xiaolong @ 2019-10-28 8:46 UTC (permalink / raw)
To: Min JiaqiX; +Cc: dev, stable
On 10/28, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: ae2bdd0219cb ("net/ice: support MTU setting")
We should set max frame size to HW in the beginning when the driver was introduced, so
the fix commit should be 50370662b727 ("net/ice: support device and queue ops")
Fix this while merging.
>Cc: stable@dpdk.org
>
>Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>---
>v2:
>* Changed commit message.
>---
> drivers/net/ice/ice_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 022b58c01..403305cfb 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>
> pf->adapter_stopped = false;
>
>+ /* Set the max frame size */
>+ ice_aq_set_mac_cfg(hw,
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>+
Why set the max frame size to HW in start ops, not in init stage like in i40e?
and what if max_rx_pkt_len hasn't been set?
Thanks,
Xiaolong
> return 0;
>
> /* stop the started queues if failed to start all queues */
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-stable] [PATCH v2] net/ice: fix setting max frame size
[not found] <20191024190818.36524-1-jiaqix.min@intel.com>
@ 2019-10-28 15:54 ` Min JiaqiX
2019-10-28 8:46 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-10-29 12:54 ` [dpdk-stable] [PATCH v3] " Min JiaqiX
0 siblings, 2 replies; 11+ messages in thread
From: Min JiaqiX @ 2019-10-28 15:54 UTC (permalink / raw)
To: dev; +Cc: Min JiaqiX, stable
Max frame size is not set to HW, so packets above the MTU
do not get dropped by HW. The patch fixed the issue.
Fixes: ae2bdd0219cb ("net/ice: support MTU setting")
Cc: stable@dpdk.org
Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
---
v2:
* Changed commit message.
---
drivers/net/ice/ice_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 022b58c01..403305cfb 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
pf->adapter_stopped = false;
+ /* Set the max frame size */
+ ice_aq_set_mac_cfg(hw,
+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
+
return 0;
/* stop the started queues if failed to start all queues */
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size
2019-10-28 8:46 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-10-29 2:05 ` Ye Xiaolong
0 siblings, 0 replies; 11+ messages in thread
From: Ye Xiaolong @ 2019-10-29 2:05 UTC (permalink / raw)
To: Min JiaqiX; +Cc: dev, stable
On 10/28, Ye Xiaolong wrote:
>Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
>Applied to dpdk-next-net-intel. Thanks.
Sorry for the above misleading message, this patch is still under discussion,
not merged yet.
Thanks,
Xiaolong
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-stable] [PATCH v3] net/ice: fix setting max frame size
2019-10-28 15:54 ` [dpdk-stable] [PATCH v2] net/ice: fix setting max frame size Min JiaqiX
2019-10-28 8:46 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-10-29 12:54 ` Min JiaqiX
2019-10-30 5:21 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-10-30 10:04 ` [dpdk-stable] [PATCH v4] " Min JiaqiX
1 sibling, 2 replies; 11+ messages in thread
From: Min JiaqiX @ 2019-10-29 12:54 UTC (permalink / raw)
To: dev; +Cc: Min JiaqiX, stable
Max frame size is not set to HW, so packets above the MTU
do not get dropped by HW. The patch fixed the issue.
Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: stable@dpdk.org
Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
v3:
* Changed Fixes line.
v2:
* Changed commit message.
---
drivers/net/ice/ice_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 022b58c01..403305cfb 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
pf->adapter_stopped = false;
+ /* Set the max frame size */
+ ice_aq_set_mac_cfg(hw,
+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
+
return 0;
/* stop the started queues if failed to start all queues */
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
2019-10-29 12:54 ` [dpdk-stable] [PATCH v3] " Min JiaqiX
@ 2019-10-30 5:21 ` Ye Xiaolong
2019-10-30 6:40 ` Min, JiaqiX
2019-10-30 10:04 ` [dpdk-stable] [PATCH v4] " Min JiaqiX
1 sibling, 1 reply; 11+ messages in thread
From: Ye Xiaolong @ 2019-10-30 5:21 UTC (permalink / raw)
To: Min JiaqiX; +Cc: dev, stable
Hi, Jiaqi
On 10/29, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: 50370662b727 ("net/ice: support device and queue ops")
>Cc: stable@dpdk.org
>
>Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Sorry, the Reviewed-by was given by accident in V1.
>---
>v3:
>* Changed Fixes line.
>v2:
>* Changed commit message.
>---
> drivers/net/ice/ice_ethdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index 022b58c01..403305cfb 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
>
> pf->adapter_stopped = false;
>
>+ /* Set the max frame size */
>+ ice_aq_set_mac_cfg(hw,
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>+
As I commented in V2, what if user doesn't set mtu, then the max_rx_pkt_len
would be 0, do we need a default max frame value in this case?
Thanks,
Xiaolong
> return 0;
>
> /* stop the started queues if failed to start all queues */
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
2019-10-30 5:21 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-10-30 6:40 ` Min, JiaqiX
0 siblings, 0 replies; 11+ messages in thread
From: Min, JiaqiX @ 2019-10-30 6:40 UTC (permalink / raw)
To: Ye, Xiaolong; +Cc: dev, stable
Hi, Xiaolong
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Wednesday, October 30, 2019 1:22 PM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
>
> Hi, Jiaqi
>
> On 10/29, Min JiaqiX wrote:
> >Max frame size is not set to HW, so packets above the MTU do not get
> >dropped by HW. The patch fixed the issue.
> >
> >Fixes: 50370662b727 ("net/ice: support device and queue ops")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
>
> Sorry, the Reviewed-by was given by accident in V1.
Reviewed-by in next patch will be removed.
>
> >---
> >v3:
> >* Changed Fixes line.
> >v2:
> >* Changed commit message.
> >---
> > drivers/net/ice/ice_ethdev.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev)
> >
> > pf->adapter_stopped = false;
> >
> >+ /* Set the max frame size */
> >+ ice_aq_set_mac_cfg(hw,
> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
> >+
>
> As I commented in V2, what if user doesn't set mtu, then the
> max_rx_pkt_len would be 0, do we need a default max frame value in this
> case?
Agree. Add check if 0 and default max frame value in this case to next patch.
>
> Thanks,
> Xiaolong
>
> > return 0;
> >
> > /* stop the started queues if failed to start all queues */
> >--
> >2.17.1
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-stable] [PATCH v4] net/ice: fix setting max frame size
2019-10-29 12:54 ` [dpdk-stable] [PATCH v3] " Min JiaqiX
2019-10-30 5:21 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-10-30 10:04 ` Min JiaqiX
2019-11-04 2:56 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-04 15:33 ` [dpdk-stable] [PATCH v5] " Min JiaqiX
1 sibling, 2 replies; 11+ messages in thread
From: Min JiaqiX @ 2019-10-30 10:04 UTC (permalink / raw)
To: dev; +Cc: Min JiaqiX, stable
Max frame size is not set to HW, so packets above the MTU
do not get dropped by HW. The patch fixed the issue.
Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: stable@dpdk.org
Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
---
v4:
* Removed Reviewed-by
* Checked and set defaut max frame size to HW in start ops.
v3:
* Changed Fixes line.
v2:
* Changed commit message.
---
drivers/net/ice/ice_ethdev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index d74675842..d8aa68f07 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2724,6 +2724,16 @@ ice_dev_start(struct rte_eth_dev *dev)
pf->adapter_stopped = false;
+ /* Set the max frame size to default value*/
+ if (pf->dev_data->dev_conf.rxmode.max_rx_pkt_len == 0) {
+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len =
+ RTE_ETHER_MAX_LEN;
+ }
+
+ /* Set the max frame size to HW*/
+ ice_aq_set_mac_cfg(hw,
+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
+
return 0;
/* stop the started queues if failed to start all queues */
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size
2019-10-30 10:04 ` [dpdk-stable] [PATCH v4] " Min JiaqiX
@ 2019-11-04 2:56 ` Ye Xiaolong
2019-11-04 7:05 ` Min, JiaqiX
2019-11-04 15:33 ` [dpdk-stable] [PATCH v5] " Min JiaqiX
1 sibling, 1 reply; 11+ messages in thread
From: Ye Xiaolong @ 2019-11-04 2:56 UTC (permalink / raw)
To: Min JiaqiX; +Cc: dev, stable
On 10/30, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: 50370662b727 ("net/ice: support device and queue ops")
>Cc: stable@dpdk.org
>
>Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>
>---
>v4:
>* Removed Reviewed-by
>* Checked and set defaut max frame size to HW in start ops.
>v3:
>* Changed Fixes line.
>v2:
>* Changed commit message.
>---
> drivers/net/ice/ice_ethdev.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index d74675842..d8aa68f07 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2724,6 +2724,16 @@ ice_dev_start(struct rte_eth_dev *dev)
>
> pf->adapter_stopped = false;
>
>+ /* Set the max frame size to default value*/
>+ if (pf->dev_data->dev_conf.rxmode.max_rx_pkt_len == 0) {
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len =
>+ RTE_ETHER_MAX_LEN;
I think ICE_FRAME_SIZE_MAX is more suitable here.
>+ }
>+
>+ /* Set the max frame size to HW*/
>+ ice_aq_set_mac_cfg(hw,
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
What about
max_frame_size = pf->dev_data->dev_conf.rxmode.max_rx_pkt_len ?
pf->dev_data->dev_conf.rxmode.max_rx_pkt_len : ICE_FRAME_SIZE_MAX;
/* Set the max frame size to HW*/
ice_aq_set_mac_cfg(hw, max_frame_size, NULL);
Thanks,
Xiaolong
>+
> return 0;
>
> /* stop the started queues if failed to start all queues */
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size
2019-11-04 2:56 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-11-04 7:05 ` Min, JiaqiX
0 siblings, 0 replies; 11+ messages in thread
From: Min, JiaqiX @ 2019-11-04 7:05 UTC (permalink / raw)
To: Ye, Xiaolong; +Cc: dev, stable
Hi, Xiaolong
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Monday, November 4, 2019 10:57 AM
> To: Min, JiaqiX <jiaqix.min@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] net/ice: fix setting max frame size
>
> On 10/30, Min JiaqiX wrote:
> >Max frame size is not set to HW, so packets above the MTU do not get
> >dropped by HW. The patch fixed the issue.
> >
> >Fixes: 50370662b727 ("net/ice: support device and queue ops")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
> >
> >---
> >v4:
> >* Removed Reviewed-by
> >* Checked and set defaut max frame size to HW in start ops.
> >v3:
> >* Changed Fixes line.
> >v2:
> >* Changed commit message.
> >---
> > drivers/net/ice/ice_ethdev.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> >diff --git a/drivers/net/ice/ice_ethdev.c
> >b/drivers/net/ice/ice_ethdev.c index d74675842..d8aa68f07 100644
> >--- a/drivers/net/ice/ice_ethdev.c
> >+++ b/drivers/net/ice/ice_ethdev.c
> >@@ -2724,6 +2724,16 @@ ice_dev_start(struct rte_eth_dev *dev)
> >
> > pf->adapter_stopped = false;
> >
> >+ /* Set the max frame size to default value*/
> >+ if (pf->dev_data->dev_conf.rxmode.max_rx_pkt_len == 0) {
> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len =
> >+ RTE_ETHER_MAX_LEN;
>
> I think ICE_FRAME_SIZE_MAX is more suitable here.
Agree. Will be modified in Patch v5.
>
> >+ }
> >+
> >+ /* Set the max frame size to HW*/
> >+ ice_aq_set_mac_cfg(hw,
> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL);
>
> What about
>
> max_frame_size = pf->dev_data-
> >dev_conf.rxmode.max_rx_pkt_len ?
> pf->dev_data->dev_conf.rxmode.max_rx_pkt_len :
> ICE_FRAME_SIZE_MAX;
Agree. Will be modified in Patch v5.
>
> /* Set the max frame size to HW*/
> ice_aq_set_mac_cfg(hw, max_frame_size, NULL);
>
>
> Thanks,
> Xiaolong
> >+
> > return 0;
> >
> > /* stop the started queues if failed to start all queues */
> >--
> >2.17.1
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-stable] [PATCH v5] net/ice: fix setting max frame size
2019-10-30 10:04 ` [dpdk-stable] [PATCH v4] " Min JiaqiX
2019-11-04 2:56 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2019-11-04 15:33 ` Min JiaqiX
2019-11-05 2:22 ` Ye Xiaolong
1 sibling, 1 reply; 11+ messages in thread
From: Min JiaqiX @ 2019-11-04 15:33 UTC (permalink / raw)
To: dev; +Cc: xiaolong.ye, Min JiaqiX, stable
Max frame size is not set to HW, so packets above the MTU
do not get dropped by HW. The patch fixed the issue.
Fixes: 50370662b727 ("net/ice: support device and queue ops")
Cc: stable@dpdk.org
Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
---
v5:
* Set `ICE_FRAME_SIZE_MAX` to to default value.
v4:
* Removed Reviewed-by
* Checked and set defaut max frame size to HW in start ops.
v3:
* Changed Fixes line.
v2:
* Changed commit message.
---
drivers/net/ice/ice_ethdev.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index d74675842..741a067f9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2657,6 +2657,7 @@ ice_dev_start(struct rte_eth_dev *dev)
struct ice_vsi *vsi = pf->main_vsi;
uint16_t nb_rxq = 0;
uint16_t nb_txq, i;
+ uint16_t max_frame_size;
int mask, ret;
/* program Tx queues' context in hardware */
@@ -2724,6 +2725,15 @@ ice_dev_start(struct rte_eth_dev *dev)
pf->adapter_stopped = false;
+ /* Set the max frame size to default value*/
+ max_frame_size = pf->dev_data->dev_conf.rxmode.max_rx_pkt_len ?
+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len :
+ ICE_FRAME_SIZE_MAX;
+
+ /* Set the max frame size to HW*/
+ ice_aq_set_mac_cfg(hw,
+ max_frame_size, NULL);
+
return 0;
/* stop the started queues if failed to start all queues */
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-stable] [PATCH v5] net/ice: fix setting max frame size
2019-11-04 15:33 ` [dpdk-stable] [PATCH v5] " Min JiaqiX
@ 2019-11-05 2:22 ` Ye Xiaolong
0 siblings, 0 replies; 11+ messages in thread
From: Ye Xiaolong @ 2019-11-05 2:22 UTC (permalink / raw)
To: Min JiaqiX; +Cc: dev, stable
On 11/04, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: 50370662b727 ("net/ice: support device and queue ops")
>Cc: stable@dpdk.org
>
>Signed-off-by: Min JiaqiX <jiaqix.min@intel.com>
>
>---
>v5:
>* Set `ICE_FRAME_SIZE_MAX` to to default value.
>v4:
>* Removed Reviewed-by
>* Checked and set defaut max frame size to HW in start ops.
>v3:
>* Changed Fixes line.
>v2:
>* Changed commit message.
>---
> drivers/net/ice/ice_ethdev.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index d74675842..741a067f9 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2657,6 +2657,7 @@ ice_dev_start(struct rte_eth_dev *dev)
> struct ice_vsi *vsi = pf->main_vsi;
> uint16_t nb_rxq = 0;
> uint16_t nb_txq, i;
>+ uint16_t max_frame_size;
> int mask, ret;
>
> /* program Tx queues' context in hardware */
>@@ -2724,6 +2725,15 @@ ice_dev_start(struct rte_eth_dev *dev)
>
> pf->adapter_stopped = false;
>
>+ /* Set the max frame size to default value*/
>+ max_frame_size = pf->dev_data->dev_conf.rxmode.max_rx_pkt_len ?
>+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len :
>+ ICE_FRAME_SIZE_MAX;
>+
>+ /* Set the max frame size to HW*/
>+ ice_aq_set_mac_cfg(hw,
>+ max_frame_size, NULL);
>+
> return 0;
>
> /* stop the started queues if failed to start all queues */
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-05 2:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20191024190818.36524-1-jiaqix.min@intel.com>
2019-10-28 15:54 ` [dpdk-stable] [PATCH v2] net/ice: fix setting max frame size Min JiaqiX
2019-10-28 8:46 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-10-29 2:05 ` Ye Xiaolong
2019-10-29 12:54 ` [dpdk-stable] [PATCH v3] " Min JiaqiX
2019-10-30 5:21 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-10-30 6:40 ` Min, JiaqiX
2019-10-30 10:04 ` [dpdk-stable] [PATCH v4] " Min JiaqiX
2019-11-04 2:56 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-04 7:05 ` Min, JiaqiX
2019-11-04 15:33 ` [dpdk-stable] [PATCH v5] " Min JiaqiX
2019-11-05 2:22 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).