From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Simei Su <simei.su@intel.com>
Cc: qi.z.zhang@intel.com, beilei.xing@intel.com,
qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/ice: correct key len and queues check for RSS
Date: Wed, 30 Oct 2019 13:16:48 +0800 [thread overview]
Message-ID: <20191030051648.GD11315@intel.com> (raw)
In-Reply-To: <1572403945-192506-1-git-send-email-simei.su@intel.com>
On 10/30, Simei Su wrote:
>This patch corrects key_len and queues check. The key_len and queues
>are not supported to configure for RSS in rte_flow.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>Cc: stable@dpdk.org
>
>Signed-off-by: Simei Su <simei.su@intel.com>
>---
> drivers/net/ice/ice_hash.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
>diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
>index f710b97..f78fe42 100644
>--- a/drivers/net/ice/ice_hash.c
>+++ b/drivers/net/ice/ice_hash.c
>@@ -25,8 +25,6 @@
> #include "ice_ethdev.h"
> #include "ice_generic_flow.h"
>
>-#define ICE_ACTION_RSS_MAX_QUEUE_NUM 32
>-
> struct rss_type_match_hdr {
> uint32_t hdr_mask;
> uint64_t eth_rss_hint;
>@@ -333,15 +331,15 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> RTE_FLOW_ERROR_TYPE_ACTION, action,
> "a nonzero RSS encapsulation level is not supported");
>
>- if (rss->key_len == 0)
>+ if (rss->key_len)
> return rte_flow_error_set(error, ENOTSUP,
> RTE_FLOW_ERROR_TYPE_ACTION, action,
>- "RSS hash key_len mustn't be 0");
>+ "a nonzero RSS key_len is not supported");
>
>- if (rss->queue_num > ICE_ACTION_RSS_MAX_QUEUE_NUM)
>+ if (rss->queue)
> return rte_flow_error_set(error, ENOTSUP,
> RTE_FLOW_ERROR_TYPE_ACTION, action,
>- "too many queues for RSS context");
>+ "a non-NULL RSS queue is not supported");
>
> /* Check hash function and save it to rss_meta. */
> if (rss->func ==
>--
>1.8.3.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
prev parent reply other threads:[~2019-10-30 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 2:52 Simei Su
2019-10-30 3:13 ` Zhang, Qi Z
2019-10-30 5:16 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030051648.GD11315@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).