From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 553E2A0353 for ; Tue, 5 Nov 2019 13:08:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E8A9D2BAC; Tue, 5 Nov 2019 13:08:40 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by dpdk.org (Postfix) with ESMTP id 46AFE2BAC; Tue, 5 Nov 2019 13:08:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eqETiJTu0a/g2B7+0mZyzLCT1GUC0F3uiTJjBfMsWUH217tcWWtmUkv0jFfd62p8uCO17nqSKLZBXaQvizLl1f+G4hrfVfxydcCxIXz7DcrMa650/vm65Ndd1ZvZ8G29pmYgleVdoCynjUYTcZ/tosTpRQB+0F2UPn1YJ7TQDfQyHzye2HRoL4b0ELLJnByj44eDC14rcYPbE/xG0zRw+nAlyQraINK+vScLhHs/QiMTkJHXGJewI96oPGm4Hk6liceRsVU8/LRCjIOQxnuSii26lGPpUzFhhHNhwT2nd144svynRClv8NrXGqn0806sApW64lrv6pwhQFNlyd7TJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Yc+qm6YvN70RDR5CFwuBPAsARToGaKBqhpdFgGm/ZU=; b=FLlNQ4te1xdo7CkbjpK2zBLvjhDnRF5/xsG6O+ijHu88H1Xk8fKwnoxEZItpLB/4LPH+SvG0Y+wISB1n91DIky1P4ydnqBO8mEWgSQcLjla49DpT1GOlmPAZfQ+aYwaeXUYXf6fnxBGVVwr82rv7/gpl/5Wtqnd/0Hz1NIe9nHY4sb/LAlhI8sxJOxoUz+xxWl/TdXOsAmVxuquuFR6vSa7tWtk9iT04q457OZ4pOjXmrinKRvMTGMKlVF8D+m/Gp1wgZBFUVnhMOaFRt+dzf5mNQyoe77OEYpQg2vgs6M3pESGMlSYGxxix61PnxeMiRSgq0rnl4bPXqRSId2v44A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Yc+qm6YvN70RDR5CFwuBPAsARToGaKBqhpdFgGm/ZU=; b=CE3C/GrHq50Pd5GU1F4BYnh/c+asQQjLrDNtbj2cVs7IQuJ95w0xyOsh+xOHT/MV93I6BLlhgpZz3/mllPNAbNJQ1WkOE1dto+OD2ZKh9W7DLIZ6WyOB/7samVQkMRaNye8+OFBPsyn+Pl6V4MK/R2j2Vl6Av2aaCQl3XcPmdmc= Received: from AM0PR05MB6562.eurprd05.prod.outlook.com (20.179.33.11) by AM0PR05MB5763.eurprd05.prod.outlook.com (20.178.114.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Tue, 5 Nov 2019 12:08:38 +0000 Received: from AM0PR05MB6562.eurprd05.prod.outlook.com ([fe80::8b8:c07c:6ac5:439b]) by AM0PR05MB6562.eurprd05.prod.outlook.com ([fe80::8b8:c07c:6ac5:439b%3]) with mapi id 15.20.2408.024; Tue, 5 Nov 2019 12:08:38 +0000 From: Jack Min To: Thomas Monjalon CC: "dev@dpdk.org" , Ori Kam , Slava Ovsiienko , Adrien Mazarguil , Ferruh Yigit , Andrew Rybchenko , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec Thread-Index: AQHVk7nQIhbCA97BL0+6wLcYeLajqKd8WzEAgAAgwQA= Date: Tue, 5 Nov 2019 12:08:38 +0000 Message-ID: <20191105120814.hx4tnoz5ytqozd6n@mellanox.com> References: <1580ef9551619fbe0a1f85590cebaf4b026f7f0b.1572944613.git.jackmin@mellanox.com> <4507833.CEzoxxxZIU@xps> In-Reply-To: <4507833.CEzoxxxZIU@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK0PR03CA0002.apcprd03.prod.outlook.com (2603:1096:203:2e::14) To AM0PR05MB6562.eurprd05.prod.outlook.com (2603:10a6:208:13b::11) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jackmin@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [2408:8025:348:1390:7c72:199:aa05:8cf8] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d5a2ddf7-15b9-41ae-9801-08d761e8e3ce x-ms-traffictypediagnostic: AM0PR05MB5763:|AM0PR05MB5763: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0212BDE3BE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(199004)(189003)(86362001)(316002)(8936002)(2906002)(1076003)(52116002)(486006)(476003)(6486002)(71200400001)(71190400001)(6512007)(76176011)(6506007)(386003)(186003)(36756003)(14454004)(25786009)(5660300002)(305945005)(6116002)(46003)(229853002)(14444005)(256004)(7736002)(6246003)(54906003)(66476007)(4326008)(66556008)(64756008)(66946007)(6436002)(6916009)(66446008)(11346002)(99286004)(446003)(81156014)(81166006)(2616005)(102836004)(478600001)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB5763; H:AM0PR05MB6562.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9EA2AHJnJpNki2yjtbKc49PcwUmZL+FjP4ox3C+rOaq7Ag4q8cYKTKstniB/AgxR1xU47kd136vdfYUG7J9cv4b69/sqr0UlOQtn2KPVCsusPsgsWNoaHMwOFpgvQPPUKuU9+dCm6u9hp2hiED6wkrHaydT8heCk3ZYPyRwTV2pmwWK6iVTO6TXHeX1GR67DNb0/lV4ixENHQGIe4HYf9cmoQfzvgTL71QNJIZq4zHOYeEruJPKjsKJ5/dG3S0YiuFycgQhQosB7IM/SB9phzcheXaE2ojGwM8pXTCc+CHOdoB9clv5EpEdfWBAeeyCAB3UnyGkRd9Ls66FoFWBS/8jhHbg1jopX9Jp75Cf63yD9gVPub8C7c5WxZub3hYTleq4kbGh/0XHL0J6B7sMb7Fa7SeLC9EibBtrCgTBGTag5qFW6jmag8LqoSkFEYyt+ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5a2ddf7-15b9-41ae-9801-08d761e8e3ce X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2019 12:08:38.3805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q7vQjg9h5AdFsS2QerRtxsNu5VqwOUmwKuORmQeHvr8D7Dg7ITP/4J4Rc+PD7jcpUrYqUr0d9Nm6kN5vFOkcSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5763 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: expand RSS flows based on last item spec X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, 19-11-05, 11:11, Thomas Monjalon wrote: > Hi Jack, >=20 > If it is a fix, please change your title. >=20 Ok, I will add 'fix' in title. > 05/11/2019 10:16, Xiaoyu Min: > > When rte_flow_expand_rss expands rte_flow item list based on the RSS > > types. >=20 > There is no verb in this sentence. >=20 It seems I missed some words here. I'll update it. > > In another word, it will add some rte_flow items if the user >=20 > What is "it"? >=20 I mean rte_flow_expande_rss. > > specified items are not complete, for example: > >=20 > > ... pattern eth / end actions rss type tcp end ... >=20 > Please explain why it is not complete. >=20 What I mean is user provides above instead of: ... pattern eth / ipv6 / tcp / end actions rss type tcp end ... This one is complete. > >=20 > > above flow will be expaned to: > >=20 > > ... pattern eth / end actions rss types tcp > > ... pattern eth / ipv4 / tcp / end actions rss types tcp ... > > ... pattern eth / ipv6 / tcp / end actsion rss types tcp ... >=20 > There are several typos in this text. Please check. >=20 Sure. > > However the expansion is just simply expanding items without > > checking last items' spec, means the expanded rules could have conflict= ing > > settings which is not reasonable and leads to some HW error, for > > example: >=20 > This wording is really not clear. > Please make short sentences. >=20 OK, I'll make it shorter. > > ... pattern eth type is 0x86DD / end actions rss types tcp ... > >=20 > > is expaneded to: > >=20 > > ... pattern eth type is 0x86DD / ipv4 / tcp end ... > >=20 > > which has conflicting values: 0x86DD vs. ipv4 and HW will refuse create > > flow on some NICs. > >=20 > > This patch will fix above by checking the last item's spec and try to > > complete the item list. > >=20 > > Currently only support to complete item list based on L2/L3 layer. > >=20 > > Fixes: 4ed05fcd441b ("ethdev: add flow API to expand RSS flows") > > Cc: stable@dpdk.org >=20 > Missing empty line here to separate blocks. >=20 Ok, I'll add empty line here. > > Signed-off-by: Xiaoyu Min > > --- > > lib/librte_ethdev/rte_flow.c | 132 +++++++++++++++++++++++++++++++++-- > > 1 file changed, 127 insertions(+), 5 deletions(-) >=20 > It's a big change. It needs to be carefully reviewed. >=20 >=20