From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1A64A04AB for ; Wed, 6 Nov 2019 20:02:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A2781E89E; Wed, 6 Nov 2019 20:02:35 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 4F9971E868 for ; Wed, 6 Nov 2019 20:02:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573066949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PodAppb9t0ih75//Q3LNZEsSmDpASGXw+Zdgt2BaX5k=; b=ivim8TBa4zGgD42LYRDW93NqGSM60OOLJLwBOazQuajA12XSZO9EiJ3E5ojhNbMwv3G1gV uSGmWgcoT3EnVo8A07FTe4C8hWHnN5qbha/Ga5ofy/83NibkXYPf6+BRaXrS2Xgmgxa2w5 3YUrQyCRvvXEec7o46wODI1hB/pyDI0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-164-z9mKmBsKNQix023nCUTBTg-1; Wed, 06 Nov 2019 14:02:27 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 58D868017DD; Wed, 6 Nov 2019 19:02:26 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0484B1001B35; Wed, 6 Nov 2019 19:02:24 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: david.marchand@redhat.com, Kevin Traynor , rosen.xu@intel.com, stable@dpdk.org Date: Wed, 6 Nov 2019 19:01:58 +0000 Message-Id: <20191106190203.10750-4-ktraynor@redhat.com> In-Reply-To: <20191106190203.10750-1-ktraynor@redhat.com> References: <20191001125315.6191-1-ktraynor@redhat.com> <20191106190203.10750-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: z9mKmBsKNQix023nCUTBTg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] [v2 PATCH 3/8] net/ipn3ke: fix incorrect commit check logic X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Coverity is complaining about identical code regardless of which branch of the if else is taken. Functionally it means an error will always be returned if this if else is hit. Remove the else branch. CID 337928 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_branches: The same code is executed regardless of whether n->level !=3D IPN3KE_TM_NODE_LEVEL_COS || n->n_children !=3D 0U is true, because the 'then' and 'else' branches are identical. Should one of the branches be modified, or the entire 'if' statement replaced? 1506 if (n->level !=3D IPN3KE_TM_NODE_LEVEL_COS || 1507 n->n_children !=3D 0) { 1508 return -rte_tm_error_set(error, 1509 EINVAL, 1510 RTE_TM_ERROR_TYPE_UNSPECIFIED, 1511 NULL, 1512 rte_strerror(EINVAL)); else_branch: The else branch, identical to the then branch. 1513 } else { 1514 return -rte_tm_error_set(error, 1515 EINVAL, 1516 RTE_TM_ERROR_TYPE_UNSPECIFIED, 1517 NULL, 1518 rte_strerror(EINVAL)); 1519 } Coverity issue: 337928 Fixes: c820468ac99c ("net/ipn3ke: support TM") Cc: rosen.xu@intel.com Cc: stable@dpdk.org Signed-off-by: Kevin Traynor --- drivers/net/ipn3ke/ipn3ke_tm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.= c index adf02c157..a93145d59 100644 --- a/drivers/net/ipn3ke/ipn3ke_tm.c +++ b/drivers/net/ipn3ke/ipn3ke_tm.c @@ -1511,10 +1511,4 @@ ipn3ke_tm_hierarchy_commit_check(struct rte_eth_dev = *dev, =09=09=09=09=09=09NULL, =09=09=09=09=09=09rte_strerror(EINVAL)); -=09=09=09} else { -=09=09=09=09return -rte_tm_error_set(error, -=09=09=09=09=09=09EINVAL, -=09=09=09=09=09=09RTE_TM_ERROR_TYPE_UNSPECIFIED, -=09=09=09=09=09=09NULL, -=09=09=09=09=09=09rte_strerror(EINVAL)); =09=09=09} =09=09} --=20 2.21.0