From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76C52A04AB for ; Wed, 6 Nov 2019 20:02:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 795281E8A1; Wed, 6 Nov 2019 20:02:41 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 8C59F1E88D for ; Wed, 6 Nov 2019 20:02:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573066953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBfVUDGnCJ2tftIAysnOIYHQX9OfOD11ZFjQ48qPmvU=; b=E+I7bXmpyt6A1i9erMMfVW8W5n3MGlrebgsdLj4lsFDf1afBmlne1svEuuGeBNuWB/ayiu 4EIGB6pnqYnHBNpFoTj3ilOs+bt2hCPZ4leFREW8wbq//0wuC27MelDvXg5rI2o7UtQbB/ femr6ZymWTXzy04cYV8mgqaIY0HVZlM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-UTdFlJfAODuM0gbS6rOPXg-1; Wed, 06 Nov 2019 14:02:29 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15AAC8017E0; Wed, 6 Nov 2019 19:02:28 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id B357B1001B35; Wed, 6 Nov 2019 19:02:26 +0000 (UTC) From: Kevin Traynor To: dev@dpdk.org Cc: david.marchand@redhat.com, Kevin Traynor , rosen.xu@intel.com, stable@dpdk.org Date: Wed, 6 Nov 2019 19:01:59 +0000 Message-Id: <20191106190203.10750-5-ktraynor@redhat.com> In-Reply-To: <20191106190203.10750-1-ktraynor@redhat.com> References: <20191001125315.6191-1-ktraynor@redhat.com> <20191106190203.10750-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: UTdFlJfAODuM0gbS6rOPXg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] [v2 PATCH 4/8] net/ipn3ke: remove useless if statement X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Coverity complains that this statement is not needed as the goto label is on the next line anyway. Remove the if statement. 653 ret =3D ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); CID 337930 (#1 of 1): Identical code for different branches (IDENTICAL_BRANCHES)identical_branches: The same code is executed when the condition ret is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed? 654 if (ret) 655 goto end; implicit_else: The code from the above if-then branch is identical to the code after the if statement. 656end: Coverity issue: 337930 Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: rosen.xu@intel.com Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Reviewed-by: David Marchand --- drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c b/drivers/net/ipn3ke/ipn3ke= _ethdev.c index 28d8aaf2d..af87fda6b 100644 --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c @@ -738,6 +738,5 @@ ipn3ke_cfg_probe(struct rte_vdev_device *dev) =20 =09ret =3D ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); -=09if (ret) -=09=09goto end; + end: =09if (kvlist) --=20 2.21.0