patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/l3fwd: use correct IP reserved address range
Date: Thu, 7 Nov 2019 19:24:29 -0800
Message-ID: <20191107192429.2f2609c3@hermes.lan> (raw)
In-Reply-To: <CAJFAV8yUFsYhATKwbf+TGwW9C8n-BoF1O_BN=7sXmsESp0oijA@mail.gmail.com>

On Thu, 7 Nov 2019 21:52:47 +0100
David Marchand <david.marchand@redhat.com> wrote:

> Stephen,
> 
> Do we want to fix testpmd?
> 
> $ git grep 192.*18 origin/master -- app/test-pmd/
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_src_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 1;
> origin/master:app/test-pmd/txonly.c:uint32_t tx_ip_dst_addr = (192U <<
> 24) | (18 << 16) | (0 << 8) | 2;
> 
> Commit bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
> 

Yes, that should be fixed.
Ideally it should use a string instead of hardcoding shifts.


      reply	other threads:[~2019-11-08  3:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191105160921.6951-1-stephen@networkplumber.org>
2019-11-06  5:36 ` Hemant Agrawal
2019-11-07 20:52   ` David Marchand
2019-11-08  3:24     ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107192429.2f2609c3@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git