patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Cui LunyuanX <lunyuanx.cui@intel.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
	Yang Qiming <qiming.yang@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix link status
Date: Wed, 13 Nov 2019 15:17:02 +0800	[thread overview]
Message-ID: <20191113071701.GH4784@intel.com> (raw)
In-Reply-To: <20191113125555.88840-1-lunyuanx.cui@intel.com>

On 11/13, Cui LunyuanX wrote:
>After ports reset, tx laser register will be reset. The link
>status for 82599eb got from link status register was not correct.
>Set tx laser disable after ports reset.
>
>Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update")
>Cc: stable@dpdk.org
>
>Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 8c1caac18..5e516599c 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -1298,6 +1298,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
> 	/* enable support intr */
> 	ixgbe_enable_intr(eth_dev);
> 
>+	ixgbe_dev_set_link_down(eth_dev);
>+
> 	/* initialize filter info */
> 	memset(filter_info, 0,
> 	       sizeof(struct ixgbe_filter_info));
>@@ -4154,11 +4156,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> 		link_up = 0;
> 
> 	if (link_up == 0) {
>-		if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>-			intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG;
>-			rte_eal_alarm_set(10,
>-				ixgbe_dev_setup_link_alarm_handler, dev);
>-		}

why do we need this change?

Thanks,
Xiaolong

> 		return rte_eth_linkstatus_set(dev, &link);
> 	}
> 
>-- 
>2.17.1
>

  reply	other threads:[~2019-11-13  7:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 12:55 [dpdk-stable] " Cui LunyuanX
2019-11-13  7:17 ` Ye Xiaolong [this message]
2019-11-13 16:34 ` [dpdk-stable] [PATCH v2] " Cui LunyuanX
2019-11-13 15:06   ` [dpdk-stable] [dpdk-dev] " Ilya Maximets
2019-11-14  3:45     ` Cui, LunyuanX
2019-11-14 11:03       ` Ilya Maximets
2019-11-18 10:13   ` [dpdk-stable] [PATCH v3] " Lunyuan Cui
2019-11-18  3:25     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-18 15:37     ` [dpdk-stable] [PATCH v4] " Lunyuan Cui
2019-11-19  6:27       ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-19  6:39         ` Cui, LunyuanX
2019-11-26  2:05       ` [dpdk-stable] " Lu, Wenzhuo
2019-11-26  2:27         ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113071701.GH4784@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=lunyuanx.cui@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).