From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73EC9A04C8 for ; Fri, 15 Nov 2019 05:26:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 246691F5; Fri, 15 Nov 2019 05:26:55 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C592E1F5 for ; Fri, 15 Nov 2019 05:26:53 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 20:26:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,307,1569308400"; d="scan'208";a="199076119" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga008.jf.intel.com with ESMTP; 14 Nov 2019 20:26:51 -0800 Date: Fri, 15 Nov 2019 12:27:30 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: stable@dpdk.org, Zhike Wang Message-ID: <20191115042729.GA24818@___> References: <20191114151615.27375-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191114151615.27375-1-maxime.coquelin@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-stable] [17.11 LTS PATCH] vhost: fix vring requests validation broken if no FD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Nov 14, 2019 at 04:16:15PM +0100, Maxime Coquelin wrote: > From: Zhike Wang > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > so validate_msg_fds() will return error. In this case, > the negotiation of vring message between vhost user front end and > back end would fail, and as a result, vhost user link could NOT be up. > > How to reproduce: > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > 2.Notice that inside ovs there are endless logs regarding failure to > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > > Fixes: 1f6147d9a01f ("vhost: fix possible denial of service by leaking FDs") > Cc: stable@dpdk.org > > Signed-off-by: Zhike Wang > Reviewed-by: Maxime Coquelin > --- > > Backport not tested yet. > > lib/librte_vhost/vhost_user.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index d4643dc350..0f8e0df8c7 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1409,6 +1409,7 @@ vhost_user_msg_handler(int vid, int fd) > struct VhostUserMsg msg; > int ret; > int unlock_required = 0; > + int expected_fds; > > dev = get_device(vid); > if (dev == NULL) > @@ -1586,12 +1587,16 @@ vhost_user_msg_handler(int vid, int fd) > break; > > case VHOST_USER_SET_VRING_KICK: > - if (validate_msg_fds(&msg, 1) != 0) > + expected_fds = > + (msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1; > + if (validate_msg_fds(&msg, expected_fds) != 0) > return -1; > > vhost_user_set_vring_kick(&dev, &msg); > break; > case VHOST_USER_SET_VRING_CALL: > + expected_fds = > + (msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1; > if (validate_msg_fds(&msg, 1) != 0) Typo, s/1/expected_fds/ > return -1; > > @@ -1599,6 +1604,8 @@ vhost_user_msg_handler(int vid, int fd) > break; > > case VHOST_USER_SET_VRING_ERR: > + expected_fds = > + (msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK) ? 0 : 1; > if (validate_msg_fds(&msg, 1) != 0) Ditto. Thanks, Tiwei > return -1; > > -- > 2.21.0 >