From: Olivier Matz <olivier.matz@6wind.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
david.marchand@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 2/2] mempool: remove check for bad IOVA when populating
Date: Fri, 15 Nov 2019 09:48:34 +0100 [thread overview]
Message-ID: <20191115084834.GG4841@platinum> (raw)
In-Reply-To: <d541158e2c590c0d3e1a985e2bbea4c236da1f9f.1573739893.git.anatoly.burakov@intel.com>
On Thu, Nov 14, 2019 at 01:58:21PM +0000, Anatoly Burakov wrote:
> Currently, mempool will check if IOVA is bad for a segment, and reject
> the IOVA if hugepages are also enabled. This check is wrong because now
> that we have external memory segments, they are allowed to have their
> IOVA's to be invalid. This check also doesn't make much sense in the
> first place, because the following code can handle bad IOVA's perfectly
> well (and in fact, this check is not triggering a failure when
> --no-huge option is enabled), so there is not much sense to check for
> this in the first place.
>
> Fixes: 950e8fb4e194 ("mem: allow registering external memory areas")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2019-11-15 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 13:58 [dpdk-stable] [PATCH 1/2] mempool: use actual IOVA addresses " Anatoly Burakov
2019-11-14 13:58 ` [dpdk-stable] [PATCH 2/2] mempool: remove check for bad IOVA " Anatoly Burakov
2019-11-15 8:48 ` Olivier Matz [this message]
2019-11-19 1:45 ` Li, WenjieX A
2019-11-15 8:46 ` [dpdk-stable] [PATCH 1/2] mempool: use actual IOVA addresses " Olivier Matz
2019-11-15 10:12 ` Burakov, Anatoly
2019-11-19 1:45 ` Li, WenjieX A
2019-11-19 20:56 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115084834.GG4841@platinum \
--to=olivier.matz@6wind.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).