patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] devtools: fix example build with old pkg-config
Date: Fri, 15 Nov 2019 10:41:35 +0000
Message-ID: <20191115104135.GA1517@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191115103525.94786-1-ferruh.yigit@intel.com>

On Fri, Nov 15, 2019 at 10:35:25AM +0000, Ferruh Yigit wrote:
> The old version of the pkg-config [1] doesn't support '-define-prefix'
> and '--path' arguments which is causing failure building the
> examples [2].
> 

Yes for the define-prefix option, no for the path one.

The define-prefix argument is indeed necessary to have a properly working
pkg-config to get cflags/ldflags in this case, so we need to skip the tests
without it. However, the path parameter is only used to properly track the
dependencies of the build to enable rebuilding if the pkg-config file
itself changes. Therefore, having no output from pkg-config --path won't
cause the build to fail, so it's more an optional flag.

/Bruce

  reply	other threads:[~2019-11-15 10:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 10:35 Ferruh Yigit
2019-11-15 10:41 ` Bruce Richardson [this message]
     [not found] ` <20191115151700.64354-1-bruce.richardson@intel.com>
2019-11-15 15:16   ` [dpdk-stable] [PATCH v2 1/2] devtools: fix example builds with older pkg-config Bruce Richardson
2019-11-15 15:17   ` [dpdk-stable] [PATCH v2 2/2] examples: suppress errors for missing pkg-config path flag Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115104135.GA1517@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git