From: Lunyuan Cui <lunyuanx.cui@intel.com>
To: dev@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Lunyuan Cui <lunyuanx.cui@intel.com>,
stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2] net/e1000: fix link status update
Date: Fri, 15 Nov 2019 14:48:23 +0000 [thread overview]
Message-ID: <20191115144823.3647-1-lunyuanx.cui@intel.com> (raw)
In-Reply-To: <20191113173243.90826-1-lunyuanx.cui@intel.com>
Unassigned variable should not be used as judgment, and there
is no need to update link status according to old link status.
This patch fix the issue.
Fixes: 80ba61115e77 ("net/e1000: use link status helper functions")
Cc: stable@dpdk.org
Signed-off-by: Lunyuan Cui <lunyuanx.cui@intel.com>
---
drivers/net/e1000/em_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 9a88b50b2..7959ee4e9 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -1157,7 +1157,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete)
memset(&link, 0, sizeof(link));
/* Now we check if a transition has happened */
- if (link_check && (link.link_status == ETH_LINK_DOWN)) {
+ if (link_check) {
uint16_t duplex, speed;
hw->mac.ops.get_link_up_info(hw, &speed, &duplex);
link.link_duplex = (duplex == FULL_DUPLEX) ?
@@ -1167,7 +1167,7 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete)
link.link_status = ETH_LINK_UP;
link.link_autoneg = !(dev->data->dev_conf.link_speeds &
ETH_LINK_SPEED_FIXED);
- } else if (!link_check && (link.link_status == ETH_LINK_UP)) {
+ } else {
link.link_speed = ETH_SPEED_NUM_NONE;
link.link_duplex = ETH_LINK_HALF_DUPLEX;
link.link_status = ETH_LINK_DOWN;
--
2.17.1
next prev parent reply other threads:[~2019-11-15 6:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 17:32 [dpdk-stable] [PATCH] " Cui LunyuanX
2019-11-14 6:41 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-15 14:48 ` Lunyuan Cui [this message]
2019-11-18 3:06 ` [dpdk-stable] [dpdk-dev] [PATCH v2] " Ye Xiaolong
2019-11-18 3:21 ` Cui, LunyuanX
2019-11-18 3:28 ` Ye Xiaolong
2019-11-18 14:58 ` [dpdk-stable] [PATCH v3] " Lunyuan Cui
2019-11-18 7:23 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-19 6:43 ` [dpdk-stable] " Lu, Wenzhuo
2019-11-20 9:22 ` [dpdk-stable] [PATCH v4] " Lunyuan Cui
2019-11-26 2:24 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2019-11-26 2:04 ` [dpdk-stable] [PATCH] " Lu, Wenzhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115144823.3647-1-lunyuanx.cui@intel.com \
--to=lunyuanx.cui@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).