From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 825F9A04C3 for ; Fri, 22 Nov 2019 15:42:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7B0231C0B; Fri, 22 Nov 2019 15:42:12 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 717312C23 for ; Fri, 22 Nov 2019 15:42:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574433729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58vAxYwOnKnmcxtRdjaG5Vio1GQsbF3Kb+T8dtfHJGI=; b=fvrERmL3lbgv0Wdj1y7y7rNHlKLsnS059miyAdMVCwC6694qzxDeuyfZCbLDSpeN2W5OLY IqMPZlwt4k+3hGhe3nnE8Ajhh5EYD+ruwD7n0VFqcePVscTk5mhgGMObOikSldpHxB3urI ZMbhC7L/WsN6OMMecTdNDBDkx1sS4xA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-2rHSU2BfPY2tufr_fyuT8w-1; Fri, 22 Nov 2019 09:42:06 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 48246107ACC5; Fri, 22 Nov 2019 14:42:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3AD068516; Fri, 22 Nov 2019 14:42:04 +0000 (UTC) From: Kevin Traynor To: Ruifeng Wang Cc: Gavin Hu , dpdk stable Date: Fri, 22 Nov 2019 14:40:58 +0000 Message-Id: <20191122144131.21231-12-ktraynor@redhat.com> In-Reply-To: <20191122144131.21231-1-ktraynor@redhat.com> References: <20191122144131.21231-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 2rHSU2BfPY2tufr_fyuT8w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/ixgbe: remove memory barrier from NEON Rx' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/4f0b4165a401061e93= e7155bf6936b88281718e7 Thanks. Kevin. --- >From 4f0b4165a401061e93e7155bf6936b88281718e7 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Wed, 28 Aug 2019 16:24:53 +0800 Subject: [PATCH] net/ixgbe: remove memory barrier from NEON Rx [ upstream commit 18b7d4eb3dca9e24208c8be59a8972e7f9d7d1cf ] The memory barrier was intended for descriptor data integrity (see comments in [1]). As later NEON loads were implemented and a whole entry is loaded in one-run and atomic, that makes the ordering of partial loading unnecessary. Remove it accordingly. Corrected couple of code comments. In terms of performance, observed slightly higher average throughput in tests with 82599ES NIC. [1] http://patches.dpdk.org/patch/18153/ Fixes: 989a84050542 ("net/ixgbe: fix received packets number for ARM NEON") Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ix= gbe_rxtx_vec_neon.c index edb138354..86fb3afdb 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c @@ -215,5 +215,5 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct r= te_mbuf **rx_pkts, =09=09uint32_t stat; =20 -=09=09/* B.1 load 1 mbuf point */ +=09=09/* B.1 load 2 mbuf point */ =09=09mbp1 =3D vld1q_u64((uint64_t *)&sw_ring[pos]); =20 @@ -221,5 +221,5 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct r= te_mbuf **rx_pkts, =09=09vst1q_u64((uint64_t *)&rx_pkts[pos], mbp1); =20 -=09=09/* B.1 load 1 mbuf point */ +=09=09/* B.1 load 2 mbuf point */ =09=09mbp2 =3D vld1q_u64((uint64_t *)&sw_ring[pos + 2]); =20 @@ -229,5 +229,4 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct r= te_mbuf **rx_pkts, =09=09descs[2] =3D vld1q_u64((uint64_t *)(rxdp + 2)); =09=09descs[3] =3D vld1q_u64((uint64_t *)(rxdp + 3)); -=09=09rte_smp_rmb(); =20 =09=09/* B.2 copy 2 mbuf point into rx_pkts */ --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-11-22 14:36:55.867853769 +0000 +++ 0012-net-ixgbe-remove-memory-barrier-from-NEON-Rx.patch=092019-11-22 14= :36:55.154150205 +0000 @@ -1 +1 @@ -From 18b7d4eb3dca9e24208c8be59a8972e7f9d7d1cf Mon Sep 17 00:00:00 2001 +From 4f0b4165a401061e93e7155bf6936b88281718e7 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 18b7d4eb3dca9e24208c8be59a8972e7f9d7d1cf ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org