From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8339A04C3 for ; Fri, 22 Nov 2019 15:42:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FC661C0B; Fri, 22 Nov 2019 15:42:14 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 8EC382C2B for ; Fri, 22 Nov 2019 15:42:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574433733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nO7ZgfBzP6XhV1Fb7I+vaegvqnc8uhapuFIpPeWKLYE=; b=KRIYnqvgajJy6W1QgcOagZHZ2Z1sa8B7tf0ikW6tcN4nfzrH8TB366lcdxVYhrqdJg4BKt cuXxJgkMX3UU4hyxoStMApzX7yFstyezfy5sGCjMSTw2RPUJ4yLct5Wa4ABUCEoIZ5UGVx B4OGd+KHL4egC9mJ+xdmpHBknfD1Zxc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-F6ilhm9-P2ygrpi0GCeEXA-1; Fri, 22 Nov 2019 09:42:09 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 639371800D41; Fri, 22 Nov 2019 14:42:08 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51F668516; Fri, 22 Nov 2019 14:42:07 +0000 (UTC) From: Kevin Traynor To: Maxime Leroy Cc: Yong Wang , dpdk stable Date: Fri, 22 Nov 2019 14:41:00 +0000 Message-Id: <20191122144131.21231-14-ktraynor@redhat.com> In-Reply-To: <20191122144131.21231-1-ktraynor@redhat.com> References: <20191122144131.21231-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: F6ilhm9-P2ygrpi0GCeEXA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/vmxnet3: remove IP checksum from capabilities' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/bdc587ea58e70d0c67= 8b9a08dfeac210e2bf4cb5 Thanks. Kevin. --- >From bdc587ea58e70d0c678b9a08dfeac210e2bf4cb5 Mon Sep 17 00:00:00 2001 From: Maxime Leroy Date: Tue, 13 Aug 2019 15:29:47 +0200 Subject: [PATCH] net/vmxnet3: remove IP checksum from capabilities [ upstream commit 86536da001c03d2bcbdb38ccdcd023e6d744f5b8 ] The vmxnet3_prep_pkts function set rte_errno to ENOTSUP for any packets having PKT_TX_IP_CHECKSUM set in ol_flags. But the vmxnet3 has DEV_TX_OFFLOAD_IPV4_CKSUM set in this tx offload capa. This issue has been introduced with the new Rx offload API. DEV_TX_OFFLOAD_IPV4_CKSUM and DEV_RX_OFFLOAD_IPV4_CKSUM has been added to the tx/rx offloads capa, but the vmxnet3 driver doesn't support it. To fix the issue, DEV_TX/RX_OFFLOAD_IPV4_CKSUM needs to be removed from tx/rx offload capa. Fixes: 95e4a96ccbf1 ("net/vmxnet3: convert to new Rx offload API") Signed-off-by: Maxime Leroy Acked-by: Yong Wang --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmx= net3_ethdev.c index c856b77f8..c5c1b24c5 100644 --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c @@ -45,5 +45,4 @@ #define VMXNET3_TX_OFFLOAD_CAP=09=09\ =09(DEV_TX_OFFLOAD_VLAN_INSERT |=09\ -=09 DEV_TX_OFFLOAD_IPV4_CKSUM |=09\ =09 DEV_TX_OFFLOAD_TCP_CKSUM |=09\ =09 DEV_TX_OFFLOAD_UDP_CKSUM |=09\ @@ -55,5 +54,4 @@ =09 DEV_RX_OFFLOAD_VLAN_FILTER | \ =09 DEV_RX_OFFLOAD_SCATTER |=09\ -=09 DEV_RX_OFFLOAD_IPV4_CKSUM |=09\ =09 DEV_RX_OFFLOAD_UDP_CKSUM |=09\ =09 DEV_RX_OFFLOAD_TCP_CKSUM |=09\ --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-11-22 14:36:55.975127963 +0000 +++ 0014-net-vmxnet3-remove-IP-checksum-from-capabilities.patch=092019-11-2= 2 14:36:55.165149970 +0000 @@ -1 +1 @@ -From 86536da001c03d2bcbdb38ccdcd023e6d744f5b8 Mon Sep 17 00:00:00 2001 +From bdc587ea58e70d0c678b9a08dfeac210e2bf4cb5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 86536da001c03d2bcbdb38ccdcd023e6d744f5b8 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 57feb3773..9cd5eb65b 100644 +index c856b77f8..c5c1b24c5 100644