From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A89FAA04C3 for ; Fri, 22 Nov 2019 15:41:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C21723D; Fri, 22 Nov 2019 15:41:56 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 15E8B23D for ; Fri, 22 Nov 2019 15:41:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574433712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rCMnlbL+9Cee/CTnlCdUpnekX2SyAJ85P4LIWiSfNA8=; b=XAw6+D/qNeGr2Ri5pGCkhtViUpntfxypWN9go/KZzy8r1dZoIU21+8Obo8E2oeAQ7salKG rkl1T/2KGofcybTmBF89qb5Jw7Rmqjx9VEApYt9ZjwhVgfwEyR8wDq/PUjDKuO7UBmBr4y SNIEsB+QIxsBUGNpeGyCrSs9v4SfPZI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-4idyyzsNPZqyxL3JygNA0w-1; Fri, 22 Nov 2019 09:41:51 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C6F6184CAA1; Fri, 22 Nov 2019 14:41:50 +0000 (UTC) Received: from rh.redhat.com (unknown [10.36.118.60]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4188D6E71A; Fri, 22 Nov 2019 14:41:47 +0000 (UTC) From: Kevin Traynor To: David Marchand Cc: Chas Williams , dpdk stable Date: Fri, 22 Nov 2019 14:40:49 +0000 Message-Id: <20191122144131.21231-3-ktraynor@redhat.com> In-Reply-To: <20191122144131.21231-1-ktraynor@redhat.com> References: <20191122144131.21231-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: 4idyyzsNPZqyxL3JygNA0w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Subject: [dpdk-stable] patch 'net/bonding: fix unicast packets filtering' has been queued to LTS release 18.11.6 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/19. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasi= ng (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/1707c309ae28077a9d= b58a52aee3e5a14100f9c6 Thanks. Kevin. --- >From 1707c309ae28077a9db58a52aee3e5a14100f9c6 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 10 Apr 2019 14:53:48 +0200 Subject: [PATCH] net/bonding: fix unicast packets filtering [ upstream commit 0ec234460b9282c96033282a9679e88d2df5e58e ] By default, the 802.3ad code enables promisc mode on all slaves. To avoid all packets going to the application (unless the application asked for promiscuous mode), all frames are supposed to be filtered in the rx burst handler. However the incriminated commit broke this because non pure ethernet frames (basically any unicast Ether()/IP() packet) are not filtered anymore. Fixes: 71b7b37ec959 ("net/bonding: use ptype flags for LACP Rx filtering") Signed-off-by: David Marchand Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/r= te_eth_bond_pmd.c index 3f8d3ba87..2fc19fbb1 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -302,11 +302,4 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, u= int16_t nb_pkts, =09=09/* Handle slow protocol packets. */ =09=09while (j < num_rx_total) { - -=09=09=09/* If packet is not pure L2 and is known, skip it */ -=09=09=09if ((bufs[j]->packet_type & ~RTE_PTYPE_L2_ETHER) !=3D 0) { -=09=09=09=09j++; -=09=09=09=09continue; -=09=09=09} - =09=09=09if (j + 3 < num_rx_total) =09=09=09=09rte_prefetch0(rte_pktmbuf_mtod(bufs[j + 3], void *)); --=20 2.21.0 --- Diff of the applied patch vs upstream commit (please double-check if non-= empty: --- --- -=092019-11-22 14:36:55.380431474 +0000 +++ 0003-net-bonding-fix-unicast-packets-filtering.patch=092019-11-22 14:36= :55.113151081 +0000 @@ -1 +1 @@ -From 0ec234460b9282c96033282a9679e88d2df5e58e Mon Sep 17 00:00:00 2001 +From 1707c309ae28077a9db58a52aee3e5a14100f9c6 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 0ec234460b9282c96033282a9679e88d2df5e58e ] + @@ -16 +17,0 @@ -Cc: stable@dpdk.org @@ -25 +26 @@ -index 44af5ade1..49e38f6b1 100644 +index 3f8d3ba87..2fc19fbb1 100644 @@ -28 +29 @@ -@@ -305,11 +305,4 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, = uint16_t nb_pkts, +@@ -302,11 +302,4 @@ rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, = uint16_t nb_pkts,